hailin0 commented on code in PR #8626:
URL: https://github.com/apache/seatunnel/pull/8626#discussion_r1947503557
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/redshift/RedshiftCatalog.java:
##########
@@ -32,28 +31,22 @@
import lombok.extern.slf4j.Slf4j;
-import java.sql.Connection;
import java.sql.ResultSet;
import java.sql.SQLException;
-import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
@Slf4j
public class RedshiftCatalog extends AbstractJdbcCatalog {
private final String SELECT_COLUMNS =
"SELECT * FROM INFORMATION_SCHEMA.COLUMNS WHERE TABLE_SCHEMA =
'%s' AND TABLE_NAME ='%s' ORDER BY ordinal_position ASC";
- protected final Map<String, Connection> connectionMap;
Review Comment:
remove duplicate code
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/oceanbase/OceanBaseMySqlCatalog.java:
##########
@@ -204,55 +204,53 @@ protected String getDropDatabaseSql(String databaseName) {
@Override
public CatalogTable getTable(String sqlQuery) throws SQLException {
- try (Connection connection = getConnection(defaultUrl)) {
Review Comment:
cache closed connection
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java:
##########
@@ -360,20 +356,6 @@ public List<String> listViews(String databaseName)
}
}
- public List<String> listSynonym(String databaseName)
Review Comment:
move to saphana catalog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
