hailin0 commented on code in PR #8622:
URL: https://github.com/apache/seatunnel/pull/8622#discussion_r1947543615
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/master/JobMaster.java:
##########
@@ -235,19 +235,27 @@ public synchronized void init(long
initializationTimestamp, boolean restart) thr
jobImmutableInformation.getJobId(),
jobImmutableInformation.getPluginJarsUrls()));
ClassLoader appClassLoader =
Thread.currentThread().getContextClassLoader();
- ClassLoader classLoader =
- seaTunnelServer
- .getClassLoaderService()
- .getClassLoader(
- jobImmutableInformation.getJobId(),
- jobImmutableInformation.getPluginJarsUrls());
+
+ List<Set<URL>> logicalVertexJarsList =
jobImmutableInformation.getLogicalVertexJarsList();
+ List<ClassLoader> classLoaders = new ArrayList<>();
Review Comment:
```suggestion
List<ClassLoader> logicalVertexClassLoaders = new ArrayList<>();
```
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/master/JobMaster.java:
##########
@@ -256,8 +264,15 @@ public synchronized void init(long
initializationTimestamp, boolean restart) thr
logicalDag.getLogicalVertexMap().values().stream()
.map(LogicalVertex::getAction)
.filter(action -> action instanceof SinkAction)
- .map(sink -> ((SinkAction<?, ?, ?, ?>) sink).getSink())
- .forEach(JobMaster::handleSaveMode);
+ .forEach(
+ sink -> {
+ Thread.currentThread()
+ .setContextClassLoader(
+
classLoaderMap.get(sink.getId()));
+ JobMaster.handleSaveMode(
+ ((SinkAction<?, ?, ?, ?>)
sink).getSink());
+ });
+ Thread.currentThread().setContextClassLoader(appClassLoader);
Review Comment:
Use `try-finally`?
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/master/JobMaster.java:
##########
@@ -235,19 +235,27 @@ public synchronized void init(long
initializationTimestamp, boolean restart) thr
jobImmutableInformation.getJobId(),
jobImmutableInformation.getPluginJarsUrls()));
ClassLoader appClassLoader =
Thread.currentThread().getContextClassLoader();
- ClassLoader classLoader =
- seaTunnelServer
- .getClassLoaderService()
- .getClassLoader(
- jobImmutableInformation.getJobId(),
- jobImmutableInformation.getPluginJarsUrls());
+
+ List<Set<URL>> logicalVertexJarsList =
jobImmutableInformation.getLogicalVertexJarsList();
+ List<ClassLoader> classLoaders = new ArrayList<>();
+ for (Set<URL> urls : logicalVertexJarsList) {
+ classLoaders.add(
+ seaTunnelServer
+ .getClassLoaderService()
+
.getClassLoader(jobImmutableInformation.getJobId(), urls));
+ }
logicalDag =
- CustomClassLoadedObject.deserializeWithCustomClassLoader(
+ DAGUtils.restoreLogicalDag(
+ jobImmutableInformation,
nodeEngine.getSerializationService(),
- classLoader,
- jobImmutableInformation.getLogicalDag());
+ classLoaders);
+
+ Map<Long, ClassLoader> classLoaderMap = new HashMap<>();
Review Comment:
```suggestion
Map<Long, ClassLoader> logicalVertexIdClassLoaderMap = new
HashMap<>();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
