litiliu commented on code in PR #8724:
URL: https://github.com/apache/seatunnel/pull/8724#discussion_r1955784084
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkWriter.java:
##########
@@ -80,6 +83,7 @@ public KafkaSinkWriter(
&&
!CollectionUtils.isEmpty(pluginConfig.get(ASSIGN_PARTITIONS))) {
MessageContentPartitioner.setAssignPartitions(pluginConfig.get(ASSIGN_PARTITIONS));
}
+ isNative = pluginConfig.get(IS_NATIVE) != null &&
pluginConfig.get(IS_NATIVE);
Review Comment:
Is it better to use Boolea.True.equals(pluginConfig.get(IS_NATIVE))?
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkWriter.java:
##########
@@ -80,6 +83,7 @@ public KafkaSinkWriter(
&&
!CollectionUtils.isEmpty(pluginConfig.get(ASSIGN_PARTITIONS))) {
MessageContentPartitioner.setAssignPartitions(pluginConfig.get(ASSIGN_PARTITIONS));
}
+ isNative = pluginConfig.get(IS_NATIVE) != null &&
pluginConfig.get(IS_NATIVE);
Review Comment:
Is it better to use Boolean.True.equals(pluginConfig.get(IS_NATIVE))?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
