akulabs8 commented on code in PR #8699:
URL: https://github.com/apache/seatunnel/pull/8699#discussion_r1957164386
##########
seatunnel-connectors-v2/connector-rabbitmq/src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/config/RabbitmqBaseOptions.java:
##########
@@ -22,21 +22,19 @@
import org.apache.seatunnel.api.configuration.Option;
import org.apache.seatunnel.api.configuration.Options;
-import org.apache.seatunnel.common.config.CheckConfigUtil;
import lombok.AllArgsConstructor;
import lombok.Getter;
import lombok.Setter;
import java.io.Serializable;
import java.util.Collections;
-import java.util.HashMap;
import java.util.Map;
@Setter
@Getter
@AllArgsConstructor
-public class RabbitmqConfig implements Serializable {
+public class RabbitmqBaseOptions implements Serializable {
private String host;
private Integer port;
Review Comment:
Hey @liunaijie firstly thanks your your comments and patience .. I got
additional doubt..
if I seperate the config and options then how to handle in the
'RabbitmqClient' class
As you can see in the screenshot, some values are BaseOptions and some in
Configs..
how to handle this?
<img width="511" alt="Screenshot 2025-02-15 at 11 08 02 PM"
src="https://github.com/user-attachments/assets/0cedeb7c-27ea-4375-9d31-c857a5ccdac2";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
