This is an automated email from the ASF dual-hosted git repository.
fanjia pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git
The following commit(s) were added to refs/heads/dev by this push:
new eb706743fe [improve] Slack connector options (#8738)
eb706743fe is described below
commit eb706743fe4040855f7f79cbdab2a3b45dd1ba52
Author: Asish <[email protected]>
AuthorDate: Mon Feb 17 08:17:58 2025 +0530
[improve] Slack connector options (#8738)
Co-authored-by: asishupadhyay <[email protected]>
---
.../java/org/apache/seatunnel/api/ConnectorOptionCheckTest.java | 1 -
.../seatunnel/connectors/seatunnel/slack/client/SlackClient.java | 4 ++--
.../slack/config/{SlackConfig.java => SlackSinkOptions.java} | 2 +-
.../seatunnel/connectors/seatunnel/slack/sink/SlackSink.java | 8 ++++----
.../connectors/seatunnel/slack/sink/SlackSinkFactory.java | 8 ++++----
5 files changed, 11 insertions(+), 12 deletions(-)
diff --git
a/seatunnel-ci-tools/src/test/java/org/apache/seatunnel/api/ConnectorOptionCheckTest.java
b/seatunnel-ci-tools/src/test/java/org/apache/seatunnel/api/ConnectorOptionCheckTest.java
index 6d2bbf17e9..3f08796f76 100644
---
a/seatunnel-ci-tools/src/test/java/org/apache/seatunnel/api/ConnectorOptionCheckTest.java
+++
b/seatunnel-ci-tools/src/test/java/org/apache/seatunnel/api/ConnectorOptionCheckTest.java
@@ -180,7 +180,6 @@ public class ConnectorOptionCheckTest {
whiteList.add("SlsSinkOptions");
whiteList.add("DingTalkSinkOptions");
whiteList.add("Neo4jSinkOptions");
- whiteList.add("SlackSinkOptions");
whiteList.add("MaxcomputeSinkOptions");
whiteList.add("PaimonSinkOptions");
whiteList.add("TDengineSourceOptions");
diff --git
a/seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/client/SlackClient.java
b/seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/client/SlackClient.java
index acee3d401d..565d03bb69 100644
---
a/seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/client/SlackClient.java
+++
b/seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/client/SlackClient.java
@@ -34,8 +34,8 @@ import lombok.extern.slf4j.Slf4j;
import java.io.IOException;
import java.util.List;
-import static
org.apache.seatunnel.connectors.seatunnel.slack.config.SlackConfig.OAUTH_TOKEN;
-import static
org.apache.seatunnel.connectors.seatunnel.slack.config.SlackConfig.SLACK_CHANNEL;
+import static
org.apache.seatunnel.connectors.seatunnel.slack.config.SlackSinkOptions.OAUTH_TOKEN;
+import static
org.apache.seatunnel.connectors.seatunnel.slack.config.SlackSinkOptions.SLACK_CHANNEL;
@Slf4j
public class SlackClient {
diff --git
a/seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/config/SlackConfig.java
b/seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/config/SlackSinkOptions.java
similarity index 96%
rename from
seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/config/SlackConfig.java
rename to
seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/config/SlackSinkOptions.java
index b7235255f0..924cc58964 100644
---
a/seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/config/SlackConfig.java
+++
b/seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/config/SlackSinkOptions.java
@@ -25,7 +25,7 @@ import lombok.Data;
import java.io.Serializable;
@Data
-public class SlackConfig implements Serializable {
+public class SlackSinkOptions implements Serializable {
public static final Option<String> WEBHOOKS_URL =
Options.key("webhooks_url")
diff --git
a/seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/sink/SlackSink.java
b/seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/sink/SlackSink.java
index e4b6ad2766..214a08c403 100644
---
a/seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/sink/SlackSink.java
+++
b/seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/sink/SlackSink.java
@@ -31,7 +31,7 @@ import org.apache.seatunnel.common.config.CheckResult;
import org.apache.seatunnel.common.constants.PluginType;
import
org.apache.seatunnel.connectors.seatunnel.common.sink.AbstractSimpleSink;
import
org.apache.seatunnel.connectors.seatunnel.common.sink.AbstractSinkWriter;
-import org.apache.seatunnel.connectors.seatunnel.slack.config.SlackConfig;
+import org.apache.seatunnel.connectors.seatunnel.slack.config.SlackSinkOptions;
import
org.apache.seatunnel.connectors.seatunnel.slack.exception.SlackConnectorException;
import com.google.auto.service.AutoService;
@@ -67,9 +67,9 @@ public class SlackSink extends
AbstractSimpleSink<SeaTunnelRow, Void> {
CheckResult checkResult =
CheckConfigUtil.checkAllExists(
pluginConfig,
- SlackConfig.WEBHOOKS_URL.key(),
- SlackConfig.OAUTH_TOKEN.key(),
- SlackConfig.SLACK_CHANNEL.key());
+ SlackSinkOptions.WEBHOOKS_URL.key(),
+ SlackSinkOptions.OAUTH_TOKEN.key(),
+ SlackSinkOptions.SLACK_CHANNEL.key());
if (!checkResult.isSuccess()) {
throw new SlackConnectorException(
SeaTunnelAPIErrorCode.CONFIG_VALIDATION_FAILED,
diff --git
a/seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/sink/SlackSinkFactory.java
b/seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/sink/SlackSinkFactory.java
index 7944be1a02..a9dd6accb6 100644
---
a/seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/sink/SlackSinkFactory.java
+++
b/seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/sink/SlackSinkFactory.java
@@ -20,7 +20,7 @@ package org.apache.seatunnel.connectors.seatunnel.slack.sink;
import org.apache.seatunnel.api.configuration.util.OptionRule;
import org.apache.seatunnel.api.table.factory.Factory;
import org.apache.seatunnel.api.table.factory.TableSinkFactory;
-import org.apache.seatunnel.connectors.seatunnel.slack.config.SlackConfig;
+import org.apache.seatunnel.connectors.seatunnel.slack.config.SlackSinkOptions;
import com.google.auto.service.AutoService;
@@ -35,9 +35,9 @@ public class SlackSinkFactory implements TableSinkFactory {
public OptionRule optionRule() {
return OptionRule.builder()
.required(
- SlackConfig.WEBHOOKS_URL,
- SlackConfig.OAUTH_TOKEN,
- SlackConfig.SLACK_CHANNEL)
+ SlackSinkOptions.WEBHOOKS_URL,
+ SlackSinkOptions.OAUTH_TOKEN,
+ SlackSinkOptions.SLACK_CHANNEL)
.build();
}
}
