hailin0 commented on code in PR #8769:
URL: https://github.com/apache/seatunnel/pull/8769#discussion_r1962764747
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/BaseSinkConfig.java:
##########
@@ -214,6 +214,12 @@ public class BaseSinkConfig {
.defaultValue(FileFormat.CSV)
.withDescription("File format type, e.g. csv, orc,
parquet, text");
+ public static final Option<String> FILE_EXTENSION =
+ Options.key("file_extension")
+ .stringType()
+ .noDefaultValue()
+ .withDescription("The file extension of files");
Review Comment:
add example into description
##########
docs/en/connector-v2/sink/CosFile.md:
##########
@@ -46,6 +46,7 @@ By default, we use 2PC commit to ensure `exactly-once`
| file_name_expression | string | no |
"${transactionId}" | Only used when custom_filename is
true
|
| filename_time_format | string | no | "yyyy.MM.dd"
| Only used when custom_filename is true
|
| file_format_type | string | no | "csv"
|
|
+| file_extension | string | no | -
| Override the default file extensions with custom
file extensions
|
Review Comment:
add example into all docs
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/BaseSinkConfig.java:
##########
@@ -214,6 +214,12 @@ public class BaseSinkConfig {
.defaultValue(FileFormat.CSV)
.withDescription("File format type, e.g. csv, orc,
parquet, text");
+ public static final Option<String> FILE_EXTENSION =
+ Options.key("file_extension")
Review Comment:
or use `file_suffix`?
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/BaseSourceConfigOptions.java:
##########
@@ -34,6 +34,12 @@ public class BaseSourceConfigOptions {
.withDescription(
"File format type, e.g. json, csv, text, parquet,
orc, avro....");
+ public static final Option<String> FILE_EXTENSION =
+ Options.key("file_extension")
+ .stringType()
+ .noDefaultValue()
+ .withDescription("The file extension of files");
Review Comment:
add example into description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
