This is an automated email from the ASF dual-hosted git repository.
wanghailin pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git
The following commit(s) were added to refs/heads/dev by this push:
new 53f0a9eb52 [Fix][Connector-V2] Fix StarRocksCatalogTest#testCatalog()
NPE (#8987)
53f0a9eb52 is described below
commit 53f0a9eb52cabaa5feeb1637b352004b5ae16296
Author: xiaochen <[email protected]>
AuthorDate: Wed Mar 19 14:59:39 2025 +0800
[Fix][Connector-V2] Fix StarRocksCatalogTest#testCatalog() NPE (#8987)
---
.../client/StarRocksStreamLoadVisitor.java | 8 +--
.../starrocks/catalog/StarRocksCatalogTest.java | 83 ----------------------
.../e2e/connector/starrocks/StarRocksIT.java | 7 ++
3 files changed, 11 insertions(+), 87 deletions(-)
diff --git
a/seatunnel-connectors-v2/connector-starrocks/src/main/java/org/apache/seatunnel/connectors/seatunnel/starrocks/client/StarRocksStreamLoadVisitor.java
b/seatunnel-connectors-v2/connector-starrocks/src/main/java/org/apache/seatunnel/connectors/seatunnel/starrocks/client/StarRocksStreamLoadVisitor.java
index 4c901b60fc..73b6ba1159 100644
---
a/seatunnel-connectors-v2/connector-starrocks/src/main/java/org/apache/seatunnel/connectors/seatunnel/starrocks/client/StarRocksStreamLoadVisitor.java
+++
b/seatunnel-connectors-v2/connector-starrocks/src/main/java/org/apache/seatunnel/connectors/seatunnel/starrocks/client/StarRocksStreamLoadVisitor.java
@@ -52,8 +52,8 @@ public class StarRocksStreamLoadVisitor {
private static final String RESULT_FAILED = "Fail";
private static final String RESULT_SUCCESS = "Success";
private static final String RESULT_LABEL_EXISTED = "Label Already Exists";
- private static final String LAEBL_STATE_VISIBLE = "VISIBLE";
- private static final String LAEBL_STATE_COMMITTED = "COMMITTED";
+ private static final String LABEL_STATE_VISIBLE = "VISIBLE";
+ private static final String LABEL_STATE_COMMITTED = "COMMITTED";
private static final String RESULT_LABEL_PREPARE = "PREPARE";
private static final String RESULT_LABEL_ABORTED = "ABORTED";
private static final String RESULT_LABEL_UNKNOWN = "UNKNOWN";
@@ -225,8 +225,8 @@ public class StarRocksStreamLoadVisitor {
}
LOG.info(String.format("Checking label[%s] state[%s]\n",
label, labelState));
switch (labelState) {
- case LAEBL_STATE_VISIBLE:
- case LAEBL_STATE_COMMITTED:
+ case LABEL_STATE_VISIBLE:
+ case LABEL_STATE_COMMITTED:
return;
case RESULT_LABEL_PREPARE:
continue;
diff --git
a/seatunnel-connectors-v2/connector-starrocks/src/test/java/org/apache/seatunnel/connectors/seatunnel/starrocks/catalog/StarRocksCatalogTest.java
b/seatunnel-connectors-v2/connector-starrocks/src/test/java/org/apache/seatunnel/connectors/seatunnel/starrocks/catalog/StarRocksCatalogTest.java
deleted file mode 100644
index bdc7a15244..0000000000
---
a/seatunnel-connectors-v2/connector-starrocks/src/test/java/org/apache/seatunnel/connectors/seatunnel/starrocks/catalog/StarRocksCatalogTest.java
+++ /dev/null
@@ -1,83 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.seatunnel.connectors.seatunnel.starrocks.catalog;
-
-import org.apache.seatunnel.api.table.catalog.CatalogTable;
-import org.apache.seatunnel.api.table.catalog.TablePath;
-
-import org.junit.jupiter.api.Disabled;
-import org.junit.jupiter.api.Test;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import java.util.List;
-
-@Disabled("Please Test it in your local environment")
-public class StarRocksCatalogTest {
-
- private static final Logger LOGGER =
LoggerFactory.getLogger(StarRocksCatalogTest.class);
-
- @Test
- public void testCatalog() {
- StarRocksCatalog catalog =
- new StarRocksCatalog(
- "starrocks", "root", "123456",
"jdbc:mysql://47.108.65.163:9030/", "");
- List<String> databases = catalog.listDatabases();
- LOGGER.info("find databases: " + databases);
-
- if (!catalog.databaseExists("default")) {
- catalog.createDatabase(TablePath.of("default", null), true);
- }
-
- databases = catalog.listDatabases();
- LOGGER.info("find databases: " + databases);
-
- catalog.createTable(
- "CREATE TABLE IF NOT EXISTS `default`.`test` (\n"
- + "`recruit_date` DATE NOT NULL COMMENT
\"YYYY-MM-DD\",\n"
- + " `region_num` TINYINT COMMENT \"range
[-128, 127]\",\n"
- + " `num_plate` SMALLINT COMMENT \"range
[-32768, 32767] \",\n"
- + " `tel` INT COMMENT \"range
[-2147483648, 2147483647]\",\n"
- + " `id` BIGINT COMMENT \"range
[-2^63 + 1 ~ 2^63 - 1]\",\n"
- + " `password` LARGEINT COMMENT \"range
[-2^127 + 1 ~ 2^127 - 1]\",\n"
- + " `name` CHAR(20) NOT NULL COMMENT
\"range char(m),m in (1-255)\",\n"
- + " `profile` VARCHAR(500) NOT NULL COMMENT
\"upper limit value 1048576 bytes\",\n"
- + " `hobby` STRING NOT NULL COMMENT
\"upper limit value 65533 bytes\",\n"
- + " `leave_time` DATETIME COMMENT
\"YYYY-MM-DD HH:MM:SS\",\n"
- + " `channel` FLOAT COMMENT \"4
bytes\",\n"
- + " `income` DOUBLE COMMENT \"8
bytes\",\n"
- + " `account` DECIMAL(12,4) COMMENT \"\",\n"
- + " `ispass` BOOLEAN COMMENT
\"true/false\"\n"
- + ") ENGINE=OLAP\n"
- + "DUPLICATE KEY(`recruit_date`, `region_num`)\n"
- + "PARTITION BY RANGE(`recruit_date`)\n"
- + "(\n"
- + " PARTITION p20220311 VALUES [('2022-03-11'),
('2022-03-12')),\n"
- + " PARTITION p20220312 VALUES [('2022-03-12'),
('2022-03-13')),\n"
- + " PARTITION p20220313 VALUES [('2022-03-13'),
('2022-03-14')),\n"
- + " PARTITION p20220314 VALUES [('2022-03-14'),
('2022-03-15')),\n"
- + " PARTITION p20220315 VALUES [('2022-03-15'),
('2022-03-16'))\n"
- + ")"
- + " DISTRIBUTED BY HASH (`id`)\n"
- + " PROPERTIES (\n"
- + " \"replication_num\" = \"1\" \n"
- + " );");
- CatalogTable table = catalog.getTable(TablePath.of("default", "test"));
- LOGGER.info("find table: " + table);
- }
-}
diff --git
a/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-starrocks-e2e/src/test/java/org/apache/seatunnel/e2e/connector/starrocks/StarRocksIT.java
b/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-starrocks-e2e/src/test/java/org/apache/seatunnel/e2e/connector/starrocks/StarRocksIT.java
index 0545836aea..e87a6e68a8 100644
---
a/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-starrocks-e2e/src/test/java/org/apache/seatunnel/e2e/connector/starrocks/StarRocksIT.java
+++
b/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-starrocks-e2e/src/test/java/org/apache/seatunnel/e2e/connector/starrocks/StarRocksIT.java
@@ -421,6 +421,13 @@ public class StarRocksIT extends TestSuiteBase implements
TestResource {
String.format(URL, starRocksServer.getHost()),
"CREATE TABLE IF NOT EXISTS `${database}`.`${table}`
(\n ${rowtype_fields}\n ) ENGINE=OLAP \n DUPLICATE KEY(`BIGINT_COL`) \n
COMMENT '${comment}' \n DISTRIBUTED BY HASH (BIGINT_COL) BUCKETS 1 \n
PROPERTIES (\n \"replication_num\" = \"1\", \n \"in_memory\" = \"false\" ,
\n \"storage_format\" = \"DEFAULT\" \n )");
starRocksCatalog.open();
+
+ String tmpDB = "test_tmp";
+ if (!starRocksCatalog.databaseExists(tmpDB)) {
+ starRocksCatalog.createDatabase(TablePath.of(tmpDB, "default"),
true);
+ }
+
Assertions.assertTrue(starRocksCatalog.listDatabases().contains(tmpDB));
+
CatalogTable catalogTable =
starRocksCatalog.getTable(tablePathStarRocksSource);
catalogTable =
CatalogTable.of(
