misi1987107 commented on code in PR #8765:
URL: https://github.com/apache/seatunnel/pull/8765#discussion_r2005121438
##########
seatunnel-connectors-v2/connector-file/connector-file-ftp/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/ftp/sink/FtpFileSinkFactory.java:
##########
@@ -46,69 +46,54 @@ public String factoryIdentifier() {
@Override
public OptionRule optionRule() {
return OptionRule.builder()
- .required(FtpConfigOptions.FILE_PATH)
- .required(FtpConfigOptions.FTP_HOST)
- .required(FtpConfigOptions.FTP_PORT)
- .required(FtpConfigOptions.FTP_USERNAME)
- .required(FtpConfigOptions.FTP_PASSWORD)
+ .required(FtpFileSinkOptions.FILE_PATH)
+ .required(FtpFileSinkOptions.FTP_HOST)
+ .required(FtpFileSinkOptions.FTP_PORT)
+ .required(FtpFileSinkOptions.FTP_USERNAME)
+ .required(FtpFileSinkOptions.FTP_PASSWORD)
.optional(SinkConnectorCommonOptions.MULTI_TABLE_SINK_REPLICA)
- .optional(BaseSinkConfig.TMP_PATH)
- .optional(BaseSinkConfig.FILE_FORMAT_TYPE)
- .optional(BaseSinkConfig.SCHEMA_SAVE_MODE)
- .optional(BaseSinkConfig.DATA_SAVE_MODE)
+ .optional(FileBaseSinkOptions.TMP_PATH)
+ .optional(FileBaseSinkOptions.FILE_FORMAT_TYPE)
+ .optional(FileBaseSinkOptions.SCHEMA_SAVE_MODE)
+ .optional(FileBaseSinkOptions.DATA_SAVE_MODE)
.conditional(
- BaseSinkConfig.FILE_FORMAT_TYPE,
- FileFormat.TEXT,
- BaseSinkConfig.ROW_DELIMITER,
- BaseSinkConfig.FIELD_DELIMITER,
- BaseSinkConfig.TXT_COMPRESS,
- BaseSinkConfig.ENABLE_HEADER_WRITE)
- .conditional(
- BaseSinkConfig.FILE_FORMAT_TYPE,
- FileFormat.CSV,
- BaseSinkConfig.TXT_COMPRESS,
- BaseSinkConfig.ENABLE_HEADER_WRITE)
- .conditional(
- BaseSinkConfig.FILE_FORMAT_TYPE,
- FileFormat.JSON,
- BaseSinkConfig.TXT_COMPRESS)
- .conditional(
- BaseSinkConfig.FILE_FORMAT_TYPE,
- FileFormat.ORC,
- BaseSinkConfig.ORC_COMPRESS)
- .conditional(
- BaseSinkConfig.FILE_FORMAT_TYPE,
- FileFormat.PARQUET,
- BaseSinkConfig.PARQUET_COMPRESS,
- BaseSinkConfig.PARQUET_AVRO_WRITE_FIXED_AS_INT96,
- BaseSinkConfig.PARQUET_AVRO_WRITE_TIMESTAMP_AS_INT96)
Review Comment:
I think the
conditional( @NonNull Option<T> conditionalOption,
@NonNull T expectValue,
@NonNull Option<?>... requiredOptions)
method is a required parameter that meets the specified conditions, but
these are all non required options，
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
