Hisoka-X commented on code in PR #9103:
URL: https://github.com/apache/seatunnel/pull/9103#discussion_r2041335418
##########
docs/en/connector-v2/source/Http.md:
##########
@@ -71,6 +71,8 @@ They can be downloaded via install-plugin.sh or from the
Maven central repositor
| common-options | | No | - | Source plugin
common parameters, please refer to [Source Common
Options](../source-common-options.md) for details
|
| keep_params_as_form | Boolean | No | false |
Whether the params are submitted according to the form, used for compatibility
with legacy behaviors. When true, the value of the params parameter is
submitted through the form. |
| keep_page_param_as_http_param | Boolean | No | false
| Whether to set the paging parameters to params. For compatibility with
legacy behaviors.
|
+| json_filed_missed_return_null | Boolean | No | false
| When the json field is missing, set true return null else error.
Review Comment:
```suggestion
| json_filed_missed_return_null | Boolean | No | false
| When the json field is missing, set true return null else error. |
```
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-http-e2e/src/test/java/org/apache/seatunnel/e2e/connector/http/HttpIT.java:
##########
@@ -357,6 +357,9 @@ public void testSourceToAssertSink(TestContainer container)
Container.ExecResult execResult19 =
container.executeJob("/http_page_increase_start_num.conf");
Assertions.assertEquals(0, execResult19.getExitCode());
+
+ Container.ExecResult execResult21 =
container.executeJob("/http_to_console.conf");
+ Assertions.assertEquals(0, execResult21.getExitCode());
Review Comment:
I perfer use unit test to check it rather than e2e. Unit test can check all
return value more easier. Current e2e test case you added even not check result
data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
