Copilot commented on code in PR #9121:
URL: https://github.com/apache/seatunnel/pull/9121#discussion_r2046215810
##########
seatunnel-connectors-v2/connector-file/connector-file-cos/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/cos/source/CosFileSourceFactory.java:
##########
@@ -97,4 +101,10 @@ public OptionRule optionRule() {
public Class<? extends SeaTunnelSource> getSourceClass() {
return CosFileSource.class;
}
+
+ @Override
+ public <T, SplitT extends SourceSplit, StateT extends Serializable>
+ TableSource<T, SplitT, StateT>
createSource(TableSourceFactoryContext context) {
+ return () -> (SeaTunnelSource<T, SplitT, StateT>) new
CosFileSource(context.getOptions());
Review Comment:
Consider adding an annotation to suppress the unchecked cast warning or
handling the cast more explicitly to ensure type safety.
```suggestion
SeaTunnelSource<?, ?, ?> source = new
CosFileSource(context.getOptions());
if (!(source instanceof SeaTunnelSource<T, SplitT, StateT>)) {
throw new ClassCastException("The created source is not
compatible with the expected type.");
}
return () -> (SeaTunnelSource<T, SplitT, StateT>) source;
```
##########
seatunnel-dist/src/test/java/org/apache/seatunnel/api/connector/ConnectorSpecificationCheckTest.java:
##########
@@ -73,6 +73,9 @@ public void
testAllConnectorImplementFactoryWithUpToDateMethod() throws ClassNot
List<String> blockList = new ArrayList<>();
blockList.add("HiveSourceFactory");
blockList.add("HiveSinkFactory");
+ // adjusted the connector implementation,not deal with deprecated
method yet
+ blockList.add("CosFileSourceFactory");
Review Comment:
[nitpick] Consider adding a space after the comma for clarity, e.g.,
'connector implementation, not dealing with deprecated method yet'.
```suggestion
// adjusted the connector implementation, not deal with deprecated
method yet
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
