Copilot commented on code in PR #9220:
URL: https://github.com/apache/seatunnel/pull/9220#discussion_r2055545595
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceSplitEnumerator.java:
##########
@@ -128,7 +128,9 @@ public void open() {
executor.scheduleWithFixedDelay(
() -> {
try {
- discoverySplits();
+ if (initialized) {
Review Comment:
The condition 'if (initialized)' before calling discoverySplits helps
prevent the NPE, but the scheduling might run before run() sets initialized.
Consider reviewing the initialization order or adding comments to clarify that
delayed discovery is intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
