Hisoka-X commented on code in PR #9228:
URL: https://github.com/apache/seatunnel/pull/9228#discussion_r2059608338
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java:
##########
@@ -285,12 +285,15 @@ private void handleCoordinatorError(CheckpointCloseReason
reason, Throwable e) {
if (checkpointCoordinatorFuture.isDone()) {
return;
}
- cleanPendingCheckpoint(reason);
updateStatus(CheckpointCoordinatorStatus.FAILED);
checkpointCoordinatorFuture.complete(
new CheckpointCoordinatorState(
CheckpointCoordinatorStatus.FAILED,
errorByPhysicalVertex.get()));
checkpointManager.handleCheckpointError(pipelineId, false);
+ // we should wait the checkpoint manager handle the error to cancel
other task by use
+ // checkpoint coordinator thread pool. So we killed the thread pool at
the end of this
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
