(seatunnel) branch dev updated: [Feature][Connector-V2] Make some sink parameters optional for DataHub (#9229)

[wanghailin]

This is an automated email from the ASF dual-hosted git repository.

wanghailin pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new 7418fae10c [Feature][Connector-V2] Make some sink parameters optional 
for DataHub  (#9229)
7418fae10c is described below

commit 7418fae10c4852a016cb94d2249b3b841b6d3058
Author: jiazhang <65228898+ji...@users.noreply.github.com>
AuthorDate: Sun Apr 27 09:42:22 2025 +0800

    [Feature][Connector-V2] Make some sink parameters optional for DataHub  
(#9229)
---
 docs/en/connector-v2/sink/Datahub.md                 |  4 ++--
 docs/zh/connector-v2/sink/Datahub.md                 | 20 ++++++++++----------
 .../seatunnel/datahub/config/DataHubSinkOptions.java |  4 ++--
 .../seatunnel/datahub/sink/DataHubSinkFactory.java   |  3 ++-
 4 files changed, 16 insertions(+), 15 deletions(-)

diff --git a/docs/en/connector-v2/sink/Datahub.md 
b/docs/en/connector-v2/sink/Datahub.md
index e9fa212ade..0ef1cbd79f 100644
--- a/docs/en/connector-v2/sink/Datahub.md
+++ b/docs/en/connector-v2/sink/Datahub.md
@@ -21,8 +21,8 @@ A sink plugin which use send message to DataHub
 | accessKey      | string | yes      | -             |
 | project        | string | yes      | -             |
 | topic          | string | yes      | -             |
-| timeout        | int    | yes      | -             |
-| retryTimes     | int    | yes      | -             |
+| timeout        | int    | no       | 3000          |
+| retryTimes     | int    | no       | 3             |
 | common-options |        | no       | -             |
 
 ### endpoint [string]
diff --git a/docs/zh/connector-v2/sink/Datahub.md 
b/docs/zh/connector-v2/sink/Datahub.md
index cdb934aded..44afb3b0c6 100644
--- a/docs/zh/connector-v2/sink/Datahub.md
+++ b/docs/zh/connector-v2/sink/Datahub.md
@@ -14,16 +14,16 @@ import ChangeLog from '../changelog/connector-datahub.md';
 
 ## 选项
 
-|      名称           |  类型  | 必需 | 默认值 |
-|----------------|--------|----|---------------|
-| endpoint       | string | 是  | -             |
-| accessId       | string | 是  | -             |
-| accessKey      | string | 是  | -             |
-| project        | string | 是  | -             |
-| topic          | string | 是  | -             |
-| timeout        | int    | 是  | -             |
-| retryTimes     | int    | 是  | -             |
-| common-options |        | 否  | -             |
+|      名称           |  类型  | 必需  | 默认值  |
+|----------------|--------|-----|------|
+| endpoint       | string | 是   | -    |
+| accessId       | string | 是   | -    |
+| accessKey      | string | 是   | -    |
+| project        | string | 是   | -    |
+| topic          | string | 是   | -    |
+| timeout        | int    | 否   | 3000 |
+| retryTimes     | int    | 否   | 3    |
+| common-options |        | 否   | -    |
 
 ### endpoint [string]
 
diff --git 
a/seatunnel-connectors-v2/connector-datahub/src/main/java/org/apache/seatunnel/connectors/seatunnel/datahub/config/DataHubSinkOptions.java
 
b/seatunnel-connectors-v2/connector-datahub/src/main/java/org/apache/seatunnel/connectors/seatunnel/datahub/config/DataHubSinkOptions.java
index 09b30a9c4c..5895ffdc87 100644
--- 
a/seatunnel-connectors-v2/connector-datahub/src/main/java/org/apache/seatunnel/connectors/seatunnel/datahub/config/DataHubSinkOptions.java
+++ 
b/seatunnel-connectors-v2/connector-datahub/src/main/java/org/apache/seatunnel/connectors/seatunnel/datahub/config/DataHubSinkOptions.java
@@ -57,12 +57,12 @@ public class DataHubSinkOptions {
     public static Option<Integer> TIMEOUT =
             Options.key("timeout")
                     .intType()
-                    .noDefaultValue()
+                    .defaultValue(3000)
                     .withDescription("The max connection timeout");
 
     public static Option<Integer> RETRY_TIMES =
             Options.key("retryTimes")
                     .intType()
-                    .noDefaultValue()
+                    .defaultValue(3)
                     .withDescription("The max retry times when your client put 
record failed");
 }
diff --git 
a/seatunnel-connectors-v2/connector-datahub/src/main/java/org/apache/seatunnel/connectors/seatunnel/datahub/sink/DataHubSinkFactory.java
 
b/seatunnel-connectors-v2/connector-datahub/src/main/java/org/apache/seatunnel/connectors/seatunnel/datahub/sink/DataHubSinkFactory.java
index fcdcddf63d..a3d19a2417 100644
--- 
a/seatunnel-connectors-v2/connector-datahub/src/main/java/org/apache/seatunnel/connectors/seatunnel/datahub/sink/DataHubSinkFactory.java
+++ 
b/seatunnel-connectors-v2/connector-datahub/src/main/java/org/apache/seatunnel/connectors/seatunnel/datahub/sink/DataHubSinkFactory.java
@@ -44,8 +44,9 @@ public class DataHubSinkFactory implements TableSinkFactory {
     @Override
     public OptionRule optionRule() {
         return OptionRule.builder()
-                .required(ENDPOINT, ACCESS_ID, ACCESS_KEY, PROJECT, TOPIC, 
TIMEOUT, RETRY_TIMES)
+                .required(ENDPOINT, ACCESS_ID, ACCESS_KEY, PROJECT, TOPIC)
                 .optional(SinkConnectorCommonOptions.MULTI_TABLE_SINK_REPLICA)
+                .optional(TIMEOUT, RETRY_TIMES)
                 .build();
     }