Copilot commented on code in PR #9246:
URL: https://github.com/apache/seatunnel/pull/9246#discussion_r2065184695
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java:
##########
@@ -492,15 +492,24 @@ protected void tryTriggerPendingCheckpoint(CheckpointType
checkpointType) {
}
final long currentTimestamp = Instant.now().toEpochMilli();
if (checkpointType.notFinalCheckpoint() &&
checkpointType.notSchemaChangeCheckpoint()) {
- long diffFromLastTimestamp = currentTimestamp -
latestTriggerTimestamp.get();
- if (diffFromLastTimestamp <= 0) {
+ if (!isAllTaskReady) {
+ LOG.info("The all task not ready, skip trigger checkpoint");
Review Comment:
[nitpick] Consider revising the log message on the following line to improve
grammar. For example, change "The all task not ready, skip trigger checkpoint"
to "Not all tasks are ready, skipping checkpoint trigger."
```suggestion
LOG.info("Not all tasks are ready, skipping checkpoint
trigger");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
