Hisoka-X commented on code in PR #9184:
URL: https://github.com/apache/seatunnel/pull/9184#discussion_r2065783788
##########
docs/en/connector-v2/source/Http.md:
##########
@@ -366,14 +367,25 @@ source {
- See this link for task configuration
[http_jsonpath_to_assert.conf](../../../../seatunnel-e2e/seatunnel-connector-v2-e2e/connector-http-e2e/src/test/resources/http_jsonpath_to_assert.conf).
### pageing
-The current supported pagination type are `PageNumber` and `Cursor`.
+The current supported pagination type are `PageNumber` and `Cursor`.
if you need to use pagination, you need to configure `pageing`. the default
pagination type is `PageNumber`.
#### 1. PageNumber
-When you need to concatenate page param in the URL,then add params.
-When you need to set page param to the body,add the key of page param in body.
+When using `PageNumber` pagination, you can include page parameters in
different parts of your HTTP request:
+
+- **In URL parameters**: Add the page parameter to the `params` section
+- **In request body**: Include the page parameter in the `body` JSON
+- **In headers**: Add the page parameter to the `headers` section
+
+You can use placeholders like `${page}` with `use_placeholder_replacement =
true` to dynamically update these values. The placeholders can be used in
various formats:
+
+- As a standalone value: `"${page}"`
+- With prefix/suffix: `"10${page}"` or `"page-${page}"`
+- As a number without quotes: `${page}` (in JSON body)
+- In nested JSON structures: `{"pagination":{"page":${page}}}`
+#### Example 1: Using page parameters in body and params
Review Comment:
```suggestion
##### Example 1: Using page parameters in body and params
```
##########
docs/en/connector-v2/source/Http.md:
##########
@@ -402,9 +415,140 @@ source {
}
}
}
+```
+
+#### Example 2: Using page parameters in headers
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
