Zzih commented on code in PR #9303:
URL: https://github.com/apache/seatunnel/pull/9303#discussion_r2085846713
##########
seatunnel-connectors-v2/connector-file/connector-file-oss/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/oss/sink/OssFileSink.java:
##########
@@ -18,20 +18,24 @@
package org.apache.seatunnel.connectors.seatunnel.file.oss.sink;
import org.apache.seatunnel.api.configuration.ReadonlyConfig;
+import org.apache.seatunnel.api.sink.SupportSaveMode;
import org.apache.seatunnel.api.table.catalog.CatalogTable;
import org.apache.seatunnel.connectors.seatunnel.file.config.FileSystemType;
import org.apache.seatunnel.connectors.seatunnel.file.oss.config.OssHadoopConf;
import
org.apache.seatunnel.connectors.seatunnel.file.sink.BaseMultipleTableFileSink;
import java.util.Optional;
-public class OssFileSink extends BaseMultipleTableFileSink {
+public class OssFileSink extends BaseMultipleTableFileSink implements
SupportSaveMode {
private final CatalogTable catalogTable;
+ private final ReadonlyConfig readonlyConfig;
+
public OssFileSink(ReadonlyConfig readonlyConfig, CatalogTable
catalogTable) {
super(OssHadoopConf.buildWithConfig(readonlyConfig), readonlyConfig,
catalogTable);
this.catalogTable = catalogTable;
+ this.readonlyConfig = readonlyConfig;
Review Comment:
Sorry, I didn't see the difference...I've updated the code based on your
suggestions. Could you please take another look and let me know if there's
anything else that needs to be improved? I really appreciate your help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
