Hisoka-X commented on code in PR #9446: URL: https://github.com/apache/seatunnel/pull/9446#discussion_r2151220837
##########
docs/en/connector-v2/source/Clickhouse.md:
##########
@@ -54,14 +54,28 @@ They can be downloaded via install-plugin.sh or from the
Maven central repositor
| Name | Type | Required | Default |
Description
|
|-------------------|--------|----------|------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| host | String | Yes | - |
`ClickHouse` cluster address, the format is `host:port` , allowing multiple
`hosts` to be specified. Such as `"host1:8123,host2:8123"` .
|
-| database | String | Yes | - | The
`ClickHouse` database.
|
-| sql | String | Yes | - | The query
sql used to search data though Clickhouse server.
|
| username | String | Yes | - |
`ClickHouse` user username.
|
| password | String | Yes | - |
`ClickHouse` user password.
|
+| database | String | NO | - | The
`ClickHouse` database.
|
+| table | String | NO | - | The
`ClickHouse` table. If it is a distributed table, the cluster is obtained based
on the table engine. If it is a local table, build the cluster based on the
input `host`
|
Review Comment:
```suggestion
| table_path | String | NO | - | The
`ClickHouse` table. If it is a distributed table, the cluster is obtained based
on the table engine. If it is a local table, build the cluster based on the
input `host`
|
```
Same as JDBC
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-clickhouse-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/ClickhouseIT.java:
##########
@@ -211,6 +213,17 @@ public void testClickHouseWithMultiTableSink(TestContainer
container) throws Exc
}
}
+ @TestTemplate
+ public void testClickhouseWithParallelismRead(TestContainer testContainer)
Review Comment:
could you add test case to verify filter_query and partition_list work
properly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
