zhilinli123 commented on PR #9432: URL: https://github.com/apache/seatunnel/pull/9432#issuecomment-2986419619
> Author > I have a question and would appreciate your advice: As seen in this PR, two modules are submitted: > > ``` > seatunnel-connector-v2/connector-sensorsdata > seatunnel-format/seatunnel-format-sensorsdata > ``` > > Here, connector-sensorsdata depends on seatunnel-format-sensorsdata. > > #### Our scenario is: > On our private branch, besides connector-sensorsdata, we have several transform modules. We extracted common dependencies for these modules into seatunnel-format-sensorsdata. > > For the code submitted to the community, since seatunnel-format-sensorsdata is only used by connector-sensorsdata, it seems more reasonable to consolidate them into a single module. However, if we do this, each transform module in our private branch would need to duplicate these base classes, which isn’t practical. > > #### My questions are: > 1. Should we submit seatunnel-format-sensorsdata as an independent module to the community? > 2. If it shouldn’t be a separate module, do you have any suggestions? > One idea I have: > Release seatunnel-format-sensorsdata as a separate Maven Central artifact. > But this artifact would be specifically for Seatunnel since it depends on seatunnel-api. > > @zhilinli123 PTAL : @hailin0 @Hisoka-X -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
