Copilot commented on code in PR #9463:
URL: https://github.com/apache/seatunnel/pull/9463#discussion_r2155961835
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/master/JobMaster.java:
##########
@@ -257,7 +257,6 @@ public synchronized void init(long initializationTimestamp,
boolean restart) thr
}
try {
if (!restart
- && !logicalDag.isStartWithSavePoint()
&&
ReadonlyConfig.fromMap(logicalDag.getJobConfig().getEnvOptions())
.get(EnvCommonOptions.SAVEMODE_EXECUTE_LOCATION)
.equals(SaveModeExecuteLocation.CLUSTER)) {
Review Comment:
Removing the savepoint check may unintentionally trigger schema handling
logic during job restores, which appears contradictory to the PR title.
Consider adding a clear conditional or comment to indicate how jobs restoring
from savepoints should be handled to avoid invoking
handleSchemaSaveModeWithRestore.
```suggestion
.equals(SaveModeExecuteLocation.CLUSTER)
&& !logicalDag.isStartWithSavePoint()) { // Ensure
savepoint restores do not trigger schema handling
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
