WenDing-Y commented on code in PR #9467:
URL: https://github.com/apache/seatunnel/pull/9467#discussion_r2163078873
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-paimon-e2e/src/test/java/org/apache/seatunnel/e2e/connector/paimon/PaimonIT.java:
##########
@@ -34,9 +35,21 @@
import java.nio.file.Path;
@DisabledOnContainer(
- value = TestContainerId.FLINK_1_13,
- disabledReason = "Paimon does not support flink 1.13")
-public class PaimonIT extends TestSuiteBase {
+ value = {},
+ type = {EngineType.SPARK, EngineType.FLINK},
+ disabledReason =
+ "Spark and Flink engine can not auto create paimon table on
worker node in local file(e.g flink tm) by savemode feature which can lead
error")
Review Comment:
I attempted to resolve the issue by mounting the same file path, however,
the necessary changes would need to be made in the AbstractTestFlinkContainer
class — a shared base class. Modifying it could affect multiple tests and
introduces too much risk. As an alternative, I looked into how other test
classes handle similar cases, and decided that skipping the Spark and Flink
engines is the most practical solution.
```
@Override
public void startUp() throws Exception {
final String dockerImage = getDockerImage();
final String properties = String.join("\n", getFlinkProperties());
jobManager =
new GenericContainer<>(dockerImage)
.withCommand("jobmanager")
.withNetwork(NETWORK)
.withNetworkAliases("jobmanager")
.withExposedPorts()
.withEnv("FLINK_PROPERTIES", properties)
.withLogConsumer(
new Slf4jLogConsumer(
DockerLoggerFactory.getLogger(dockerImage + ":jobmanager")))
.waitingFor(
new LogMessageWaitStrategy()
.withRegEx(".*Starting the resource
manager.*")
.withStartupTimeout(Duration.ofMinutes(2)));
copySeaTunnelStarterToContainer(jobManager);
copySeaTunnelStarterLoggingToContainer(jobManager);
jobManager.setPortBindings(Lists.newArrayList(String.format("%s:%s",
8081, 8081)));
taskManager =
new GenericContainer<>(dockerImage)
.withCommand("taskmanager")
.withNetwork(NETWORK)
.withNetworkAliases("taskmanager")
.withEnv("FLINK_PROPERTIES", properties)
.dependsOn(jobManager)
.withLogConsumer(
new Slf4jLogConsumer(
DockerLoggerFactory.getLogger(
dockerImage +
":taskmanager")))
.waitingFor(
new LogMessageWaitStrategy()
.withRegEx(
".*Successful registration
at resource manager.*")
.withStartupTimeout(Duration.ofMinutes(2)));
Startables.deepStart(Stream.of(jobManager)).join();
Startables.deepStart(Stream.of(taskManager)).join();
// execute extra commands
executeExtraCommands(jobManager);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
