Hisoka-X commented on code in PR #9446:
URL: https://github.com/apache/seatunnel/pull/9446#discussion_r2182581548
##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/sink/file/ClickhouseTable.java:
##########
@@ -68,4 +68,24 @@ public String getLocalTableName() {
return tableName;
}
}
+
+ public String getLocalDatabase() {
+ if (distributedEngine != null) {
+ return distributedEngine.getDatabase();
+ } else {
+ return database;
+ }
+ }
+
+ public String getLocalTableIdentifier() {
+ if (distributedEngine != null) {
+ return String.format("%s.%s", getLocalDatabase(),
getLocalTableName());
+ } else {
+ return String.format("%s.%s", database, tableName);
Review Comment:
```suggestion
return getTableIdentifier();
```
##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/config/ClickhouseSourceOptions.java:
##########
@@ -20,11 +20,43 @@
import org.apache.seatunnel.api.configuration.Option;
import org.apache.seatunnel.api.configuration.Options;
+import java.util.List;
+
public class ClickhouseSourceOptions {
+ public static final int CLICKHOUSE_PART_SIZE_MIN = 1;
+ public static final int CLICKHOUSE_PART_SIZE_DEFAULT = Integer.MAX_VALUE;
+ public static final int CLICKHOUSE_BATCH_SIZE_DEFAULT = 1024;
+
+ public static final Option<Integer> CLICKHOUSE_PART_SIZE =
+ Options.key("part_size")
Review Comment:
```suggestion
Options.key("split.size")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
