Copilot commented on code in PR #9543:
URL: https://github.com/apache/seatunnel/pull/9543#discussion_r2189527788
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/master/JobMaster.java:
##########
@@ -361,6 +361,9 @@ private CheckpointConfig createJobCheckpointConfig(
Long.parseLong(
jobEnv.get(EnvCommonOptions.CHECKPOINT_TIMEOUT.key()).toString()));
}
+ if (!jobCheckpointConfig.isCheckpointEnable()) {
Review Comment:
[nitpick] Add a brief inline comment explaining why the storage config is
reset here when checkpointing is disabled to clarify intent for future
maintainers.
```suggestion
if (!jobCheckpointConfig.isCheckpointEnable()) {
// Reset the storage configuration to ensure no checkpoint
storage is used when checkpointing is disabled.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
