Hisoka-X commented on code in PR #9497:
URL: https://github.com/apache/seatunnel/pull/9497#discussion_r2191580147
##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/test/java/org/apache/seatunnel/connectors/seatunnel/http/client/HttpClientProviderTest.java:
##########
@@ -18,20 +18,70 @@
import org.apache.http.Header;
import org.apache.http.client.methods.HttpPost;
+import org.apache.http.message.BasicHeader;
+import org.apache.http.protocol.HTTP;
+import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
+import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
class HttpClientProviderTest {
+ private HttpPost mockRequest;
+
+ @BeforeEach
+ void setUp() {
+
+ mockRequest = mock(HttpPost.class);
+ }
+
+ @AfterEach
+ void tearDown() {
+ mockRequest = null;
+ }
+
+ @Test
+ void testAddBodyPreservesOriginalHeaders() throws Exception {
+ Header[] originalHeaders =
+ new Header[] {new BasicHeader(HTTP.CONTENT_TYPE,
"application/json;utf-8")};
+ when(mockRequest.getAllHeaders()).thenReturn(originalHeaders);
+ when(mockRequest.getHeaders(HTTP.CONTENT_TYPE)).thenReturn(new
Header[0]);
+
+ // verify original headers are preserved
+ HttpClientProvider.addBody(mockRequest, Collections.emptyMap());
+
+ // verify(mockRequest).setHeader(HTTP.CONTENT_TYPE,
"application/json;utf-8");
+ // verify(mockRequest).setEntity(any(HttpEntity.class));
+
+ Header[] currentHeaders =
+ new Header[] {new BasicHeader(HTTP.CONTENT_TYPE,
"application/json;utf-8")};
+ when(mockRequest.getAllHeaders()).thenReturn(currentHeaders);
+
+ Header[] resultHeaders = mockRequest.getAllHeaders();
+ Assertions.assertEquals(1, resultHeaders.length);
+ Assertions.assertEquals(HTTP.CONTENT_TYPE, resultHeaders[0].getName());
+ Assertions.assertEquals("application/json;utf-8",
resultHeaders[0].getValue());
Review Comment:
What is the purpose of this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
