Copilot commented on code in PR #9553:
URL: https://github.com/apache/seatunnel/pull/9553#discussion_r2194030242
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/mysql/MySqlTypeConverter.java:
##########
@@ -243,6 +244,7 @@ public Column convert(BasicTypeDefine typeDefine) {
builder.scale(decimalUnsignedType.getScale());
break;
case MYSQL_ENUM:
+ case MYSQL_SET:
builder.dataType(BasicType.STRING_TYPE);
if (typeDefine.getLength() == null || typeDefine.getLength()
<= 0) {
builder.columnLength(100L);
Review Comment:
The fallback default length `100L` is a magic number; consider extracting it
to a named constant (e.g., `DEFAULT_SET_LENGTH`) to improve readability and
maintainability.
```suggestion
builder.columnLength(DEFAULT_SET_LENGTH);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
