Hisoka-X commented on code in PR #9593:
URL: https://github.com/apache/seatunnel/pull/9593#discussion_r2218128480
##########
seatunnel-connectors-v2/connector-tdengine/src/main/java/org/apache/seatunnel/connectors/seatunnel/tdengine/config/TDengineCommonOptions.java:
##########
@@ -54,4 +54,13 @@ public abstract class TDengineCommonOptions {
.stringType()
.noDefaultValue()
.withDescription("The TDengine super table name");
+
+ public static final Option<String> FIELD_NAMES =
+ Options.key("field_names")
+ .stringType()
Review Comment:
Please use list type, it's better to write and read.
##########
seatunnel-connectors-v2/connector-tdengine/src/main/java/org/apache/seatunnel/connectors/seatunnel/tdengine/config/TDengineCommonOptions.java:
##########
@@ -54,4 +54,13 @@ public abstract class TDengineCommonOptions {
.stringType()
.noDefaultValue()
.withDescription("The TDengine super table name");
+
+ public static final Option<String> FIELD_NAMES =
+ Options.key("field_names")
Review Comment:
```suggestion
Options.key("read_columns")
```
##########
seatunnel-connectors-v2/connector-tdengine/src/main/java/org/apache/seatunnel/connectors/seatunnel/tdengine/config/TDengineSourceOptions.java:
##########
@@ -33,4 +33,12 @@ public class TDengineSourceOptions extends
TDengineCommonOptions {
.stringType()
.noDefaultValue()
.withDescription("The upper bound for data query range");
+
+ public static final Option<String> SUB_TABLE =
+ Options.key("sub_table")
+ .stringType()
Review Comment:
ditto
##########
seatunnel-connectors-v2/connector-tdengine/src/main/java/org/apache/seatunnel/connectors/seatunnel/tdengine/config/TDengineSourceOptions.java:
##########
@@ -33,4 +33,12 @@ public class TDengineSourceOptions extends
TDengineCommonOptions {
.stringType()
.noDefaultValue()
.withDescription("The upper bound for data query range");
+
+ public static final Option<String> SUB_TABLE =
+ Options.key("sub_table")
Review Comment:
```suggestion
Options.key("sub_tables")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
