dybyte commented on code in PR #9574:
URL: https://github.com/apache/seatunnel/pull/9574#discussion_r2222680914
##########
seatunnel-connectors-v2/connector-redis/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/source/RedisSourceFactory.java:
##########
@@ -54,7 +54,10 @@ public OptionRule optionRule() {
RedisSourceOptions.HASH_KEY_PARSE_MODE,
RedisBaseOptions.AUTH,
RedisBaseOptions.USER,
- RedisBaseOptions.KEY)
+ RedisBaseOptions.KEY,
+ RedisSourceOptions.READ_KEY_ENABLED,
+ RedisSourceOptions.SINGLE_FIELD_NAME,
+ RedisSourceOptions.KEY_FIELD_NAME)
Review Comment:
I just wanted to clarify that I think it would be sufficient to enforce only
key_field_name as required when read_key_enabled is true.
I believe making single_field_name mandatory might be unnecessary.
Please let me know if you see any reason otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
