Hisoka-X commented on code in PR #9610:
URL: https://github.com/apache/seatunnel/pull/9610#discussion_r2231106822
##########
seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/config/ElasticsearchBaseOptions.java:
##########
@@ -87,4 +87,30 @@ public class ElasticsearchBaseOptions implements
Serializable {
.stringType()
.noDefaultValue()
.withDescription("The key password for the trust store
specified");
+
+ // Authentication configuration options
+ public static final Option<String> AUTH_TYPE =
+ Options.key("auth_type")
+ .stringType()
Review Comment:
We can use enum type for `auth_type`.
```suggestion
.enumType()
```
##########
seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/sink/ElasticsearchSinkFactory.java:
##########
@@ -75,6 +79,10 @@ public OptionRule optionRule() {
TLS_KEY_STORE_PASSWORD,
TLS_TRUST_STORE_PATH,
TLS_TRUST_STORE_PASSWORD,
+ AUTH_TYPE,
+ API_KEY_ID,
+ API_KEY,
+ API_KEY_ENCODED,
Review Comment:
```suggestion
.conditional(AUTH_TYPE, "api_key",
API_KEY_ID,
API_KEY,
API_KEY_ENCODED)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
