Carl-Zhou-CN commented on code in PR #9630:
URL: https://github.com/apache/seatunnel/pull/9630#discussion_r2240038037
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaPartitionSplitReader.java:
##########
@@ -374,9 +374,6 @@ private KafkaConsumer<byte[], byte[]> initConsumer(
props.setProperty(
ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG,
ByteArrayDeserializer.class.getName());
- props.setProperty(
- ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG,
- String.valueOf(kafkaSourceConfig.isCommitOnCheckpoint()));
Review Comment:
I think we can handle it in KafkaSourceConfig, forcibly overwrite
ENABLE_AUTO_COMMIT_CONFIG to false when COMMIT_ON_CHECKPOINT is true, and give
a prompt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
