liunaijie commented on code in PR #8875:
URL: https://github.com/apache/seatunnel/pull/8875#discussion_r2032462208
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e/src/test/resources/textFormatIT/kafka_source_topic_multiple_point_text_to_console.conf:
##########
@@ -68,7 +77,7 @@ sink {
},
{
rule_type = MAX
- rule_value = 99
+ rule_value = 9
Review Comment:
why set this value to 9, I see it will write 10 records to this topic. I
sugest both set the min and max to 10.
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e/src/test/java/org/apache/seatunnel/e2e/connector/kafka/KafkaIT.java:
##########
@@ -334,11 +339,25 @@ public void
testSourceKafkaTextToConsoleAssertCatalogTable(TestContainer contain
@TestTemplate
public void testSourceKafkaTopicWithMultipleDotConsoleAssertCatalogTable(
TestContainer container) throws IOException, InterruptedException {
+ String multipleDotTopic = "test.multiple.point.topic.json";
Review Comment:
Why topic name using `json`. I see you using `TextSerializationSchema` write
data. the data format should be `text`. Please correct this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
