Hisoka-X commented on code in PR #9660:
URL: https://github.com/apache/seatunnel/pull/9660#discussion_r2253000334
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/FileBaseSinkOptions.java:
##########
@@ -108,6 +108,13 @@ public class FileBaseSinkOptions extends FileBaseOptions {
.withDescription(
"The separator between columns in a row of data.
Only needed by `text` and `csv` file format");
+ public static final Option<String> CSV_FIELD_DELIMITER =
+ Options.key("csv_field_delimiter")
+ .stringType()
+ .defaultValue(",")
+ .withDescription(
+ "The separator between columns in a row of data.
Only needed by `csv` file format");
Review Comment:
why not reuse the `field_delimiter`? we can set different default value by
ourself when format is text or csv.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
