Hisoka-X commented on code in PR #9711: URL: https://github.com/apache/seatunnel/pull/9711#discussion_r2287432371
########## docs/en/transform-v2/sql-functions.md: ########## @@ -306,27 +306,27 @@ select SPLIT(test,';') as arrays ### SOUNDEX -```SOUNDEX(string)``` +```SOUNDEX(string) -> STRING``` -Returns a four character code representing the sound of a string. This method returns a string, or null if parameter is null. See https://en.wikipedia.org/wiki/Soundex for more information. Review Comment: we should keep `or null if parameter is null. See https://en.wikipedia.org/wiki/Soundex for more information` ########## docs/en/transform-v2/sql-functions.md: ########## @@ -228,12 +226,12 @@ Flags values are limited to 'i', 'c', 'n', 'm'. Other symbols cause exception. M Example: -REGEXP_REPLACE('Hello World', ' +', ' ') Review Comment: This change should be revert. The demo it's intentional. ########## docs/en/transform-v2/sql-functions.md: ########## @@ -693,27 +693,27 @@ CURRENT_TIMESTAMP ### DATEADD / TIMESTAMPADD -```DATEADD| TIMESTAMPADD(dateAndTime, addIntLong, datetimeFieldString)``` +```DATEADD| TIMESTAMPADD(dateAndTime, addIntLong, datetimeFieldString) -> dateAndTime (same type)``` -Adds units to a date-time value. The datetimeFieldString indicates the unit. Use negative values to subtract units. addIntLong may be a long value when manipulating milliseconds, microseconds, or nanoseconds otherwise its range is restricted to int. This method returns a value with the same type as specified value if unit is compatible with this value. If specified field is a HOUR, MINUTE, SECOND, MILLISECOND, etc and value is a DATE value DATEADD returns combined TIMESTAMP. Fields DAY, MONTH, YEAR, WEEK, etc are not allowed for TIME values. Review Comment: ditto ########## docs/en/transform-v2/sql-functions.md: ########## @@ -249,11 +247,11 @@ Flags values are limited to 'i', 'c', 'n', 'm'. Other symbols cause exception. M Example: -REGEXP_LIKE('Hello World', '[A-Z ]*', 'i') Review Comment: ditto ########## docs/en/transform-v2/sql-functions.md: ########## @@ -559,77 +559,77 @@ LOG(2, A) ### LOG10 -```LOG10(numeric)``` +```LOG10(numeric) -> DOUBLE``` -Calculates the base 10 logarithm as a double value. Argument must be a positive numeric value. +Calculates the base 10 logarithm. Argument must be a positive numeric value. Example: LOG10(A) ### RADIANS -```RADIANS(numeric)``` +```RADIANS(numeric) -> DOUBLE``` -See also Java Math.toRadians. This method returns a double. +See also Java Math.toRadians. Example: RADIANS(A) ### SQRT -```SQRT(numeric)``` +```SQRT(numeric) -> DOUBLE``` -See also Java Math.sqrt. This method returns a double. +See also Java Math.sqrt. Example: SQRT(A) ### PI -```PI()``` +```PI() -> DOUBLE``` -See also Java Math.PI. This method returns a double. +See also Java Math.PI. Example: PI() ### POWER -```POWER(numeric, numeric)``` +```POWER(numeric, numeric) -> DOUBLE``` -See also Java Math.pow. This method returns a double. +See also Java Math.pow. Example: POWER(A, B) ### RAND / RANDOM -```RAND | RANDOM([ int ])``` +```RAND | RANDOM([ int ]) -> DOUBLE``` -Calling the function without parameter returns the next a pseudo random number. Calling it with an parameter seeds the session's random number generator. This method returns a double between 0 (including) and 1 (excluding). Review Comment: ditto. ########## docs/en/transform-v2/sql-functions.md: ########## @@ -559,77 +559,77 @@ LOG(2, A) ### LOG10 -```LOG10(numeric)``` +```LOG10(numeric) -> DOUBLE``` -Calculates the base 10 logarithm as a double value. Argument must be a positive numeric value. +Calculates the base 10 logarithm. Argument must be a positive numeric value. Example: LOG10(A) ### RADIANS -```RADIANS(numeric)``` +```RADIANS(numeric) -> DOUBLE``` -See also Java Math.toRadians. This method returns a double. +See also Java Math.toRadians. Example: RADIANS(A) ### SQRT -```SQRT(numeric)``` +```SQRT(numeric) -> DOUBLE``` -See also Java Math.sqrt. This method returns a double. +See also Java Math.sqrt. Example: SQRT(A) ### PI -```PI()``` +```PI() -> DOUBLE``` -See also Java Math.PI. This method returns a double. +See also Java Math.PI. Example: PI() ### POWER -```POWER(numeric, numeric)``` +```POWER(numeric, numeric) -> DOUBLE``` -See also Java Math.pow. This method returns a double. +See also Java Math.pow. Example: POWER(A, B) ### RAND / RANDOM -```RAND | RANDOM([ int ])``` +```RAND | RANDOM([ int ]) -> DOUBLE``` -Calling the function without parameter returns the next a pseudo random number. Calling it with an parameter seeds the session's random number generator. This method returns a double between 0 (including) and 1 (excluding). +Calling the function without parameter returns the next a pseudo random number. Calling it with an parameter seeds the session's random number generator. Example: RAND() ### ROUND -```ROUND(numeric[, digitsInt])``` +```ROUND(numeric[, digitsInt]) -> numeric (same type)``` -Rounds to a number of fractional digits. This method returns value of the same type as argument, but with adjusted precision and scale, if applicable. Review Comment: ditto ########## docs/en/transform-v2/sql-functions.md: ########## @@ -639,19 +639,19 @@ SIGN(N) ### TRUNC -```TRUNC | TRUNCATE(numeric[, digitsInt])``` +```TRUNC | TRUNCATE(numeric[, digitsInt]) -> numeric (same type)``` -When a numeric argument is specified, truncates it to a number of digits (to the next value closer to 0) and returns value of the same type as argument, but with adjusted precision and scale, if applicable. Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
