Hisoka-X commented on code in PR #2:
URL: https://github.com/apache/seatunnel-tools/pull/2#discussion_r2292529952
##########
pom.xml:
##########
@@ -34,24 +34,29 @@
<description>Production ready big data processing product based on Apache
Spark and Apache Flink.</description>
<modules>
- <!--
- We retrieve the config module from maven repository. If you want
to change the config module,
- you need to open this annotation and change the dependency of
config-shade to project.
- <module>seatunnel-config</module>
- -->
- <module>seatunnel</module>
Review Comment:
Please revert this. We should use sub module seatunnel as dependency, not
release version.
##########
pom.xml:
##########
@@ -34,24 +34,29 @@
<description>Production ready big data processing product based on Apache
Spark and Apache Flink.</description>
<modules>
- <!--
- We retrieve the config module from maven repository. If you want
to change the config module,
- you need to open this annotation and change the dependency of
config-shade to project.
- <module>seatunnel-config</module>
- -->
- <module>seatunnel</module>
+ <module>x2seatunnel</module>
</modules>
<properties>
- <!--todo The classification is too confusing, reclassify by type-->
+ <!-- Project coordinates -->
<revision>0.0.1-SNAPSHOT</revision>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<java.version>1.8</java.version>
- <scala.version>2.12.15</scala.version>
- <scala.binary.version>2.12</scala.binary.version>
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
+ <!-- External dependency versions for submodules (x2seatunnel) -->
+ <!-- SeaTunnel released artifacts used by tools (adjust as needed or
override with -Dseatunnel.version=...) -->
+ <seatunnel.version>2.3.11</seatunnel.version>
Review Comment:
use sub module seatunnel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
