Hisoka-X commented on code in PR #9805:
URL: https://github.com/apache/seatunnel/pull/9805#discussion_r2319121946
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/writer/CanalJsonWriteStrategy.java:
##########
@@ -45,13 +46,18 @@ public class CanalJsonWriteStrategy extends
AbstractWriteStrategy<FSDataOutputSt
private final LinkedHashMap<String, FSDataOutputStream>
beingWrittenOutputStream;
private final Map<String, Boolean> isFirstWrite;
private final Charset charset;
+ private final Map<String, String> options;
public CanalJsonWriteStrategy(FileSinkConfig textFileSinkConfig) {
super(textFileSinkConfig);
this.beingWrittenOutputStream = new LinkedHashMap<>();
this.isFirstWrite = new HashMap<>();
this.charset =
EncodingUtils.tryParseCharset(textFileSinkConfig.getEncoding());
this.rowDelimiter =
textFileSinkConfig.getRowDelimiter().getBytes(charset);
+ this.options = new HashMap<>();
+ this.options.put(
+ CanalJsonFormatOptions.MERGE_UPDATE_EVENT.key(),
+ textFileSinkConfig.getMergeUpdateEvent().toString());
Review Comment:
why introduce options? Let's keep the code simple.
##########
docs/en/connector-v2/sink/LocalFile.md:
##########
@@ -74,6 +77,7 @@ By default, we use 2PC commit to ensure `exactly-once`
| encoding | string | no | "UTF-8"
| Only used when file_format_type is
json,text,csv,xml.
|
| schema_save_mode | string | no |
CREATE_SCHEMA_WHEN_NOT_EXIST | Existing dir processing method
|
| data_save_mode | string | no | APPEND_DATA
| Existing data processing method
|
+| merge_update_event | boolean | no | false
| Only used when file_format_type is
canal_json,debezium_json,maxwell_json.set true,when serialize data,UPDATE_AFTER
and UPDATE_BEFORE event will merge into UPDATE data |
Review Comment:
```suggestion
| merge_update_event | boolean | no | false
| Only used when file_format_type is
canal_json,debezium_json or maxwell_json. When value is true, the UPDATE_AFTER
and UPDATE_BEFORE event will be merged into UPDATE event data |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
