liugddx commented on code in PR #9688:
URL: https://github.com/apache/seatunnel/pull/9688#discussion_r2319295673
##########
seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/pom.xml:
##########
@@ -151,6 +151,18 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>mysql</artifactId>
Review Comment:
E2e test case need to support flink/spark/zeta, so they should be placed in
the `seatunnel-connector-v2-e2e`.
##########
seatunnel-engine/seatunnel-engine-core/src/main/java/org/apache/seatunnel/engine/core/parse/MultipleTableJobConfigParser.java:
##########
@@ -172,7 +181,14 @@ public MultipleTableJobConfigParser(
this.jobConfig = jobConfig;
this.commonPluginJars = commonPluginJars;
this.isStartWithSavePoint = isStartWithSavePoint;
- this.seaTunnelJobConfig =
ConfigBuilder.of(Paths.get(jobDefineFilePath), variables);
+ boolean metalakeEnabled =
+
Boolean.parseBoolean(System.getenv().getOrDefault("METALAKE_ENABLED", "false"));
+ if (metalakeEnabled) {
+ this.seaTunnelJobConfig =
+
getMetalakeConfig(ConfigBuilder.of(Paths.get(jobDefineFilePath), variables));
+ } else {
+ this.seaTunnelJobConfig =
ConfigBuilder.of(Paths.get(jobDefineFilePath), variables);
+ }
Review Comment:
We need to ensure that Flink/Spark/Zeta all support this feature
simultaneously.
Therefore, it needs to be adapted in both the `FlinkTaskExecuteCommand`and
`SparkTaskExecuteCommand` classes.
##########
seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/resources/mysql_to_console_with_metalake.conf:
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+env {
+ execution.parallelism = 1
+ job.mode = "BATCH"
+}
+
+source {
+ Jdbc {
+ url =
"jdbc:mysql://mysql-e2e:3306/seatunnel?useSSL=false&serverTimezone=UTC&allowPublicKeyRetrieval=true"
+ driver = "com.mysql.cj.jdbc.Driver"
+ connection_check_timeout_sec = 100
+ sourceId = "test_catalog"
+ user = "${jdbc-user}"
+ password = "${jdbc-password}"
+ query = "select * from source"
+ }
+}
+
+transform {
+}
+
+sink {
+ Console {
Review Comment:
Please use the Assert connector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
