Carl-Zhou-CN commented on code in PR #9743: URL: https://github.com/apache/seatunnel/pull/9743#discussion_r2350533330
########## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-hive-e2e/src/test/resources/auto_table_creation/fake_to_hive_create_when_not_exist.conf: ########## @@ -0,0 +1,75 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +env { + parallelism = 1 + job.mode = "BATCH" +} + +source { + FakeSource { + schema = { + fields { + pk_id = bigint Review Comment: Could you help create a detection for all field types？ ########## seatunnel-connectors-v2/connector-hive/src/main/java/org/apache/seatunnel/connectors/seatunnel/hive/utils/HiveTypeConvertor.java: ########## @@ -56,4 +57,53 @@ public static SeaTunnelDataType<?> covertHiveTypeToSeaTunnelType(String name, St } return SeaTunnelDataTypeConvertorUtil.deserializeSeaTunnelDataType(name, hiveType); } + + public static String seatunnelToHiveType(SeaTunnelDataType<?> seaTunnelType) { + switch (seaTunnelType.getSqlType()) { + case STRING: + return "string"; + case BOOLEAN: + return "boolean"; + case TINYINT: + return "tinyint"; + case SMALLINT: + return "smallint"; + case INT: + return "int"; + case BIGINT: + return "bigint"; + case FLOAT: + return "float"; + case DOUBLE: + return "double"; + case DECIMAL: + if (seaTunnelType instanceof DecimalType) { + DecimalType decimalType = (DecimalType) seaTunnelType; + return String.format( + "decimal(%d,%d)", decimalType.getPrecision(), decimalType.getScale()); + } + return "decimal(38,18)"; + case BYTES: + return "binary"; + case DATE: + return "date"; + case TIME: + return "string"; + case TIMESTAMP: + return "timestamp"; + case ROW: + return "struct"; Review Comment: Is there an error here when struct needs to map fields？ ########## seatunnel-connectors-v2/connector-hive/src/main/java/org/apache/seatunnel/connectors/seatunnel/hive/utils/HiveTypeConvertor.java: ########## @@ -56,4 +57,53 @@ public static SeaTunnelDataType<?> covertHiveTypeToSeaTunnelType(String name, St } return SeaTunnelDataTypeConvertorUtil.deserializeSeaTunnelDataType(name, hiveType); } + + public static String seatunnelToHiveType(SeaTunnelDataType<?> seaTunnelType) { + switch (seaTunnelType.getSqlType()) { + case STRING: + return "string"; + case BOOLEAN: + return "boolean"; + case TINYINT: + return "tinyint"; + case SMALLINT: + return "smallint"; + case INT: + return "int"; + case BIGINT: + return "bigint"; + case FLOAT: + return "float"; + case DOUBLE: + return "double"; + case DECIMAL: + if (seaTunnelType instanceof DecimalType) { + DecimalType decimalType = (DecimalType) seaTunnelType; + return String.format( + "decimal(%d,%d)", decimalType.getPrecision(), decimalType.getScale()); + } + return "decimal(38,18)"; + case BYTES: + return "binary"; + case DATE: + return "date"; + case TIME: + return "string"; + case TIMESTAMP: + return "timestamp"; + case ROW: + return "struct"; + case ARRAY: + return "array"; + case MAP: + return "map"; Review Comment: ditto ########## seatunnel-connectors-v2/connector-hive/src/main/java/org/apache/seatunnel/connectors/seatunnel/hive/utils/HiveTypeConvertor.java: ########## @@ -56,4 +57,53 @@ public static SeaTunnelDataType<?> covertHiveTypeToSeaTunnelType(String name, St } return SeaTunnelDataTypeConvertorUtil.deserializeSeaTunnelDataType(name, hiveType); } + + public static String seatunnelToHiveType(SeaTunnelDataType<?> seaTunnelType) { + switch (seaTunnelType.getSqlType()) { + case STRING: + return "string"; + case BOOLEAN: + return "boolean"; + case TINYINT: + return "tinyint"; + case SMALLINT: + return "smallint"; + case INT: + return "int"; + case BIGINT: + return "bigint"; + case FLOAT: + return "float"; + case DOUBLE: + return "double"; + case DECIMAL: + if (seaTunnelType instanceof DecimalType) { + DecimalType decimalType = (DecimalType) seaTunnelType; + return String.format( + "decimal(%d,%d)", decimalType.getPrecision(), decimalType.getScale()); + } + return "decimal(38,18)"; + case BYTES: + return "binary"; + case DATE: + return "date"; + case TIME: + return "string"; + case TIMESTAMP: + return "timestamp"; + case ROW: + return "struct"; + case ARRAY: + return "array"; Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
