yzeng1618 commented on code in PR #9887:
URL: https://github.com/apache/seatunnel/pull/9887#discussion_r2380654483
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-3/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/JdbcPostgresIT.java:
##########
@@ -341,18 +346,32 @@ public void testAutoGenerateSQL(TestContainer container)
+ ".");
Assertions.assertIterableEquals(querySql(SOURCE_SQL),
querySql(SINK_SQL));
} finally {
+
executeSQL("truncate table pg_e2e_sink_table");
}
log.info(CONFIG_FILE + " e2e test completed");
}
}
+ @TestTemplate
+ public void testTimestampTzRoundTrip(TestContainer container)
Review Comment:
It can be placed in the same test case, and this will not increase the
execution time of the end-to-end (E2E) test. Currently, modifications and
optimizations are being carried out in this direction.
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-3/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/JdbcPostgresIT.java:
##########
@@ -341,18 +346,32 @@ public void testAutoGenerateSQL(TestContainer container)
+ ".");
Assertions.assertIterableEquals(querySql(SOURCE_SQL),
querySql(SINK_SQL));
} finally {
+
executeSQL("truncate table pg_e2e_sink_table");
}
log.info(CONFIG_FILE + " e2e test completed");
}
}
+ @TestTemplate
+ public void testTimestampTzRoundTrip(TestContainer container)
Review Comment:
> Since only one type has been added, can it be placed in the same case with
other type validations? This would cause the execution time of E2E to increase?
It can be placed in the same test case, and this will not increase the
execution time of the end-to-end (E2E) test. Currently, modifications and
optimizations are being carried out in this direction.
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-3/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/JdbcPostgresIT.java:
##########
@@ -341,18 +346,32 @@ public void testAutoGenerateSQL(TestContainer container)
+ ".");
Assertions.assertIterableEquals(querySql(SOURCE_SQL),
querySql(SINK_SQL));
} finally {
+
executeSQL("truncate table pg_e2e_sink_table");
}
log.info(CONFIG_FILE + " e2e test completed");
}
}
+ @TestTemplate
+ public void testTimestampTzRoundTrip(TestContainer container)
Review Comment:
It can be placed in the same test case, and this will not increase the
execution time of the end-to-end (E2E) test. Currently, modifications and
optimizations are being carried out in this direction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
