zhangshenghang commented on code in PR #9938:
URL: https://github.com/apache/seatunnel/pull/9938#discussion_r2425102977


##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-hbase-e2e/src/test/java/org/apache/seatunnel/e2e/connector/hbase/HbaseIT.java:
##########
@@ -338,6 +338,33 @@ public void testCatalog(TestContainer container) {
                 () -> catalog.dropTable(TablePath.of("", "", "tmp"), false));
     }
 
+    @TestTemplate
+    public void testHbaseSourceWithStartRowKey(TestContainer container)
+            throws IOException, InterruptedException {
+        fakeToHbaseArray(container);
+        Container.ExecResult sourceExecResult =
+                container.executeJob("/hbase-source-with-start-rowkey.conf");
+        Assertions.assertEquals(0, sourceExecResult.getExitCode());
+    }
+
+    @TestTemplate
+    public void testHbaseSourceWithEndRowKey(TestContainer container)
+            throws IOException, InterruptedException {
+        fakeToHbaseArray(container);
+        Container.ExecResult sourceExecResult =
+                container.executeJob("/hbase-source-with-end-rowkey.conf");
+        Assertions.assertEquals(0, sourceExecResult.getExitCode());
+    }
+
+    @TestTemplate
+    public void testHbaseSourceWithRowKeyRange(TestContainer container)
+            throws IOException, InterruptedException {
+        fakeToHbaseArray(container);
+        Container.ExecResult sourceExecResult =
+                container.executeJob("/hbase-source-with-rowkey-range.conf");
+        Assertions.assertEquals(0, sourceExecResult.getExitCode());
+    }
+

Review Comment:
   We need to verify in detail the number of data records written, not just 
whether the program runs successfully.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to