Cyanty commented on code in PR #9906:
URL: https://github.com/apache/seatunnel/pull/9906#discussion_r2386977792
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/BasicType.java:
##########
@@ -24,6 +24,7 @@ public class BasicType<T> implements SeaTunnelDataType<T> {
public static final BasicType<String> STRING_TYPE =
new BasicType<>(String.class, SqlType.STRING);
+ public static final BasicType<String> JSON_TYPE = new
BasicType<>(String.class, SqlType.JSON);
Review Comment:
> We already has
https://github.com/apache/seatunnel/blob/dev/seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/CommonOptions.java#L33.
So I think we can reuse this option. Not create new type.
Hi @Hisoka-X, thank you for the review.
I see now that `BasicType#JSON_TYPE` is redundant. ck sink can infer the
type from the catalog. I'll remove it in the next commit to allow writing to
JSON columns without any config changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
