Hisoka-X commented on code in PR #9867:
URL: https://github.com/apache/seatunnel/pull/9867#discussion_r2459875250


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SupportSchemaEvolutionSinkWriter.java:
##########
@@ -30,4 +32,48 @@ public interface SupportSchemaEvolutionSinkWriter {
      * @throws IOException
      */
     void applySchemaChange(SchemaChangeEvent event) throws IOException;
+
+    /**
+     * handle FlushEvent propagated from upstream
+     *
+     * @param event
+     * @throws IOException
+     */
+    default void handleFlushEvent(FlushEvent event) throws IOException {

Review Comment:
   I'm not sure why we should add new api for 
`SupportSchemaEvolutionSinkWriter`. If this api only work for flink, why not 
invoke it in flink translation layer? This PR not ready for merge it.  
@TyrantLucifer @nielifeng 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to