wuxiansen commented on code in PR #9968:
URL: https://github.com/apache/seatunnel/pull/9968#discussion_r2496875174
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/service/LogService.java:
##########
@@ -98,6 +108,40 @@ public List<Tuple3<String, String, String>>
allLogNameList(String jobId) {
return allLogNameList;
}
+ private static HttpBasic getHttpBasicAuth(HttpConfig httpConfig) {
+ String basicUser = "";
+ String basicPass = "";
+ try {
+ if (httpConfig.isEnableBasicAuth()) {
+ basicUser = httpConfig.getBasicAuthUsername();
+ basicPass = httpConfig.getBasicAuthPassword();
+ }
+ } catch (Throwable ignore) {
+ // Compatible with older versions: If HttpConfig does not have
these methods, use system
+ // properties or environment variables to find out
+ basicUser = System.getProperty("seatunnel.http.user",
System.getenv("BASIC_AUTH_USER"));
+ basicPass = System.getProperty("seatunnel.http.pass",
System.getenv("BASIC_AUTH_PASS"));
Review Comment:
Yes, I’ve considered that point. If it doesn’t actually improve backward
compatibility, I’m fine with removing this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
