liunaijie opened a new issue, #9381:
URL: https://github.com/apache/seatunnel/issues/9381

   ### Search before asking
   
   - [x] I had searched in the 
[feature](https://github.com/apache/seatunnel/issues?q=is%3Aissue+label%3A%22Feature%22)
 and found no similar feature requirement.
   
   
   ### Description
   
   When I using the Email Sink, I find it has some issue or something we can 
improve.
   
   1. when upstream field value is null, the job will get NPE
   2. when job failed, the email still send.
   3. the email attach file name is hardcode, and the field delimiter also is 
hardcode. we can make this parameters as config option.
   
   
   Related code you can refer: 
   
https://github.com/apache/seatunnel/blob/dev/seatunnel-connectors-v2/connector-email/src/main/java/org/apache/seatunnel/connectors/seatunnel/email/sink/EmailSinkWriter.java#L71
   
   
https://github.com/apache/seatunnel/blob/dev/seatunnel-connectors-v2/connector-email/src/main/java/org/apache/seatunnel/connectors/seatunnel/email/sink/EmailSinkWriter.java#L79
   
   
   
   
   
   
   ### Usage Scenario
   
   _No response_
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to