dybyte opened a new pull request, #10080:
URL: https://github.com/apache/seatunnel/pull/10080
Refer to #9995
### Purpose of this pull request
I indentified a potential root cause of the issue where a job gets stuck in
the `doing_savepoint` state.
Previously, the implementation used a loop inside a `synchronized` block
combined with `Thread.sleep()`, while updates to `pendingCounter` occurred
outside the same lock. Under this pattern, the thread in the loop may
repeatedly read a stale cached value, leading to the following scenario:
- Thread A is looping inside `synchronized(lock)`
- Thread B updates `pendingCounter` outside the synchronized block
- Thread A wakes up from `sleep` but may still read a cached value
- The stale read prevents the loop condition from changing
This can result in a potential infinite loop.
By switching to `wait()` / `notifyAll()` within the same monitor, we ensure
proper memory visibility and avoid this stale-read issue.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Not applicable.
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
