Re: [PR] [Fix][FTP]Fix 'file_filterpattern' cannot filter directories [seatunnel]

[via GitHub]

zhangshenghang commented on code in PR #10049:
URL: https://github.com/apache/seatunnel/pull/10049#discussion_r2540111844


##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/reader/AbstractReadStrategy.java:
##########
@@ -118,7 +119,7 @@ public List<String> getFileNamesByPath(String path) throws 
IOException {
             if (fileStatus.isDirectory()) {
                 // skip hidden tmp directory, such as .hive-staging_hive
                 if (!fileStatus.getPath().getName().startsWith(".")) {
-                    
fileNames.addAll(getFileNamesByPath(fileStatus.getPath().toString()));
+                    
fileNames.addAll(getFileNamesByPath(fileStatus.getPath().toUri().getPath()));

Review Comment:
   > configuration file： <img alt="image" width="801" height="275" 
src="https://private-user-images.githubusercontent.com/53458004/515467267-0e926607-9fff-498d-a0fd-ae8467e55219.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjM1MTQ5NTYsIm5iZiI6MTc2MzUxNDY1NiwicGF0aCI6Ii81MzQ1ODAwNC81MTU0NjcyNjctMGU5MjY2MDctOWZmZi00OThkLWEwZmQtYWU4NDY3ZTU1MjE5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTExMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMTE5VDAxMTA1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIzODdhNTI3MDU0NjMwOWQ5MWZmMmQ4MWUyMDNlOGE4MTEwYmRmNGZlNzgzOGM2NDIyMmM4NTgzNDM4YTk1ZjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.7P41DfHlasP-b5l6ij8Dn7KDUGo9GwpzNZWQy4gi3YM";>
 Debugging results： <img alt="image" width="1520" height="613" 
src="https://private-user-images.githubusercontent.com/53458004/515467180-f2395
 
91e-8a59-46d5-a570-3639606f478d.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjM1MTQ5NTYsIm5iZiI6MTc2MzUxNDY1NiwicGF0aCI6Ii81MzQ1ODAwNC81MTU0NjcxODAtZjIzOTU5MWUtOGE1OS00NmQ1LWE1NzAtMzYzOTYwNmY0NzhkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTExMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMTE5VDAxMTA1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBmYmJkNDJlOTk0NjQ4OTc5ZWViYmMwMDFhYWE0MTNmY2Y4YmYwZDc5MzZiNjZhYjFhMDkyNjlkZmVhYjk5M2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.dizbpC5AxdlpO2Mcr8y5MH5YPHQKQBVJmwVF2Qgr5D0">
 I think the logic is correct, what do you think?
   
   What was the previous result like? Before the modification, `s3a:/` was not 
removed; after the modification, it is removed. Will there be any other impacts?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org