zhangshenghang commented on code in PR #10013:
URL: https://github.com/apache/seatunnel/pull/10013#discussion_r2540894507
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e/src/test/java/org/apache/seatunnel/e2e/connector/kafka/KafkaIT.java:
##########
@@ -1826,88 +1883,98 @@ private void generateNativeTestData(String topic, int
start, int end) {
private Map<String, String> getKafkaConsumerData(String topicName) {
Map<String, String> data = new HashMap<>();
- try (KafkaConsumer<String, String> consumer = new
KafkaConsumer<>(kafkaConsumerConfig())) {
- consumer.subscribe(Arrays.asList(topicName));
- Map<TopicPartition, Long> offsets =
- consumer.endOffsets(Arrays.asList(new
TopicPartition(topicName, 0)));
- Long endOffset = offsets.entrySet().iterator().next().getValue();
- Long lastProcessedOffset = -1L;
-
- do {
- ConsumerRecords<String, String> records =
consumer.poll(Duration.ofMillis(100));
- for (ConsumerRecord<String, String> record : records) {
- if (lastProcessedOffset < record.offset()) {
- data.put(record.key(), record.value());
- }
- lastProcessedOffset = record.offset();
+ KafkaConsumer<String, String> consumer = new
KafkaConsumer<>(kafkaConsumerConfig());
+ consumer.subscribe(Arrays.asList(topicName));
+ Map<TopicPartition, Long> offsets =
+ consumer.endOffsets(Arrays.asList(new
TopicPartition(topicName, 0)));
+ Long endOffset = offsets.entrySet().iterator().next().getValue();
+ Long lastProcessedOffset = -1L;
+
+ do {
+ ConsumerRecords<String, String> records =
consumer.poll(Duration.ofMillis(100));
+ for (ConsumerRecord<String, String> record : records) {
+ if (lastProcessedOffset < record.offset()) {
+ data.put(record.key(), record.value());
}
- } while (lastProcessedOffset < endOffset - 1);
- }
+ lastProcessedOffset = record.offset();
+ }
+ } while (lastProcessedOffset < endOffset - 1);
+ closeKafkaConsumer(consumer);
Review Comment:
It is recommended to close it in finally
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e/src/test/java/org/apache/seatunnel/e2e/connector/kafka/KafkaIT.java:
##########
@@ -1466,12 +1522,12 @@ public void
testKafkaToKafkaExactlyOnceOnBatch(TestContainer container)
producer.flush();
}
Long endOffset;
- try (KafkaConsumer<String, String> consumer = new
KafkaConsumer<>(kafkaConsumerConfig())) {
- consumer.subscribe(Arrays.asList(producerTopic));
- Map<TopicPartition, Long> offsets =
- consumer.endOffsets(Arrays.asList(new
TopicPartition(producerTopic, 0)));
- endOffset = offsets.entrySet().iterator().next().getValue();
- }
+ KafkaConsumer<String, String> consumer = new
KafkaConsumer<>(kafkaConsumerConfig());
+ consumer.subscribe(Arrays.asList(producerTopic));
+ Map<TopicPartition, Long> offsets =
+ consumer.endOffsets(Arrays.asList(new
TopicPartition(producerTopic, 0)));
+ endOffset = offsets.entrySet().iterator().next().getValue();
+ closeKafkaConsumer(consumer);
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
