yzeng1618 opened a new pull request, #10094: URL: https://github.com/apache/seatunnel/pull/10094
<!-- Thank you for contributing to SeaTunnel! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! https://github.com/apache/seatunnel/issues/10077 ## Contribution Checklist - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues). - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc. - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`. --> ### Purpose of this pull request <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.--> - Clarify Flink checkpoint semantics for non‑CDC jobs: pure batch mode cannot use checkpoint‑based restore, while streaming mode can. - Align the actual behaviour of the Flink engine (batch vs. streaming with checkpoint.interval) with the way we describe it in the documentation and connector feature matrix. - Avoid confusing new users: the current JDBC connector docs show “batch” checked and “streaming” unchecked for Spark/Flink engines, which suggests that streaming is not supported, and does not explain the checkpoint limitation in batch mode. - Keep the feature description consistent between the SeaTunnel Zeta engine and Flink engine so that users can choose the engine with a clear understanding of checkpoint support. - Address the discussion and requirements raised in issue #10077 and make sure tests and docs cover the new behaviour. ### Does this PR introduce _any_ user-facing change? <!-- Note that it means *any* user-facing change including all aspects such as the documentation fix. If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released SeaTunnel versions or within the unreleased branches such as dev. If no, write 'No'. If you are adding/modifying connector documents, please follow our new specifications: https://github.com/apache/seatunnel/issues/4544. --> - For Flink engine, when job.mode = BATCH and checkpoint.interval > 0, submit the job in streaming runtime and enable Flink checkpointing with the configured interval. - Keep batch jobs without checkpoint.interval (or <= 0) running in pure batch runtime with checkpointing disabled. - Adjust the e2e tests so that they verify the actual checkpoint interval configured on the Flink job instead of treating batch jobs as always “checkpoint disabled”. - Align JDBC connector documentation so that the “Batch / Streaming” capability description is consistent between SeaTunnel Zeta and Flink engines, and make it explicit that checkpoint‑based restore is only supported in streaming mode for Flink (non‑CDC) jobs. ### How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. If you are adding E2E test cases, maybe refer to https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf, here is a good example. --> 1. Updated existing e2e test - org.apache.seatunnel.engine.e2e.CheckpointEnableIT#testFlinkCheckpointEnable to assert the configured checkpoint interval. 2. Existing unit tests such as - org.apache.seatunnel.core.starter.execution.RuntimeEnvironmentTest - org.apache.seatunnel.connectors.seatunnel.jdbc.catalog.utils.CatalogUtilsTest continue to pass locally. ### Check list * [ * ] If any new Jar binary package adding in your PR, please add License Notice according [New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md) * [ * ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs * [ ] If necessary, please update `incompatible-changes.md` to describe the incompatibility caused by this PR. * [ ] If you are contributing the connector code, please check that the following files are updated: 1. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it 2. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml) 3. Add ci label in [label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml) 4. Add e2e testcase in [seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/) 5. Update connector [plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
