yzeng1618 commented on code in PR #10145:
URL: https://github.com/apache/seatunnel/pull/10145#discussion_r2587097274
##########
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/zeta/functions/NumericFunction.java:
##########
@@ -208,7 +208,7 @@ private static Number round(Number v1, Number v2,
RoundingMode roundingMode) {
c:
switch (t.toUpperCase()) {
case "INTEGER":
- case "SHOT":
+ case "SHORT":
Review Comment:
Thanks for the review! The typo "SHOT" has been fixed to "SHORT" in this PR.
Regarding using Short.class.getSimpleName(), unfortunately it cannot be used in
switch-case statements because case values must be compile-time constants. We
could refactor to use if-else chains, but that would reduce readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
