yzeng1618 opened a new pull request, #10152:
URL: https://github.com/apache/seatunnel/pull/10152
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code
changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB
issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the
pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix
typo in README.md doc`.
-->
### Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull
request adds checkstyle plugin.-->
This PR limits Flink's restart attempts in E2E tests to avoid infinite retry
loops that mask real test failures with timeout errors.
<img width="2549" height="519" alt="image"
src="https://github.com/user-attachments/assets/ba7adefa-cb6d-4178-a19d-42460471b29e";
/>
Problem: In the current Flink E2E test configuration, the default restart
strategy uses maxNumberRestartAttempts=2147483647 (Integer.MAX_VALUE), causing
Flink to restart failed jobs indefinitely. When a test case fails (e.g.,
assertion validation error), Flink keeps restarting the job instead of failing
fast. This results in:
CI jobs timing out after ~1 hour of continuous restart loops
Real error messages (like AssertConnectorException: Rule validate failed)
being hidden behind generic timeout errors (The operation was canceled)
Difficult debugging as developers cannot see the actual failure cause
Solution: Configure a fixed-delay restart strategy with a maximum of 2
restart attempts and 1-second delay between retries. This allows legitimate
transient failures to recover while ensuring true test failures fail fast with
clear error messages.
### Does this PR introduce _any_ user-facing change?
No. This change only affects E2E test infrastructure configuration and does
not impact production code or user-facing behavior.
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released SeaTunnel versions or within the unreleased branches such as dev.
If no, write 'No'.
If you are adding/modifying connector documents, please follow our new
specifications: https://github.com/apache/seatunnel/issues/4544.
-->
### How was this patch tested?
- The fix was applied to AbstractTestFlinkContainer.java which is used by
all Flink-based E2E tests
- Verified that failed tests now fail quickly with proper error messages
instead of timing out after ~1 hour
- Existing E2E tests continue to pass as the restart strategy still allows
for legitimate transient failure recovery (2 retry attempts)
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If you are adding E2E test cases, maybe refer to
https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf,
here is a good example.
-->
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
