jw-itq commented on PR #10189: URL: https://github.com/apache/seatunnel/pull/10189#issuecomment-3651044880
hi @dybyte, thanks for the review!! some tests are testing basic Map behavior rather than the fix itself. I'll simplify the tests to keep only the essential ones: 1. [testCheckpointCacheCleanupAfterNotifyCheckpointComplete](cci:1://file:///Users/shiwanming/job/open-source-project/jw-itq/seatunnel/seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/task/SinkAggregatedCommitterTaskTest.java:76:4-134:5) - verifies the fix works for checkpoint completion 2. [testCheckpointCacheCleanupAfterNotifyCheckpointAborted](cci:1://file:///Users/shiwanming/job/open-source-project/jw-itq/seatunnel/seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/task/SinkAggregatedCommitterTaskTest.java:136:4-168:5) - verifies the fix works for checkpoint abort 3. [testCleanupDoesNotAffectFutureCheckpoints](cci:1://file:///Users/shiwanming/job/open-source-project/jw-itq/seatunnel/seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/task/SinkAggregatedCommitterTaskTest.java:315:4-359:5) - ensures the fix doesn't break normal operation I'll remove the other tests that are essentially testing jdk's ConcurrentHashMap behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
