(seatunnel) branch dev updated: [Improve][Connector] Replace printStackTrace with proper logging (#10176)

[shenghang]

This is an automated email from the ASF dual-hosted git repository.

shenghang pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new 86c8450a7f [Improve][Connector] Replace printStackTrace with proper 
logging (#10176)
86c8450a7f is described below

commit 86c8450a7fec06ca381062e6ed8d0fedf073cfc3
Author: mengxpgogogo-eng <mengxpgog...@gmail.com>
AuthorDate: Wed Dec 17 20:17:00 2025 +0800

    [Improve][Connector] Replace printStackTrace with proper logging (#10176)
    
    Co-authored-by: mengxp <men...@longjitech.com>
    Co-authored-by: David Zollo <davidzollo...@gmail.com>
    Co-authored-by: dy102 <132787602+dyb...@users.noreply.github.com>
---
 .../connectors/seatunnel/activemq/client/ActivemqClient.java     | 5 +++--
 .../seatunnel/graphql/source/reader/GraphQLWebSocket.java        | 9 +++++----
 .../seatunnel/connectors/seatunnel/sls/sink/SlsSinkWriter.java   | 3 +--
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git 
a/seatunnel-connectors-v2/connector-activemq/src/main/java/org/apache/seatunnel/connectors/seatunnel/activemq/client/ActivemqClient.java
 
b/seatunnel-connectors-v2/connector-activemq/src/main/java/org/apache/seatunnel/connectors/seatunnel/activemq/client/ActivemqClient.java
index 2090af4fbf..d351344446 100644
--- 
a/seatunnel-connectors-v2/connector-activemq/src/main/java/org/apache/seatunnel/connectors/seatunnel/activemq/client/ActivemqClient.java
+++ 
b/seatunnel-connectors-v2/connector-activemq/src/main/java/org/apache/seatunnel/connectors/seatunnel/activemq/client/ActivemqClient.java
@@ -63,10 +63,11 @@ public class ActivemqClient {
             log.info("connection created");
 
         } catch (Exception e) {
-            e.printStackTrace();
+            log.error("Error while creating AMQ client", e);
             throw new ActivemqConnectorException(
                     ActivemqConnectorErrorCode.CREATE_ACTIVEMQ_CLIENT_FAILED,
-                    "Error while create AMQ client ");
+                    "Error while create AMQ client ",
+                    e);
         }
     }
 
diff --git 
a/seatunnel-connectors-v2/connector-graphql/src/main/java/org/apache/seatunnel/connectors/seatunnel/graphql/source/reader/GraphQLWebSocket.java
 
b/seatunnel-connectors-v2/connector-graphql/src/main/java/org/apache/seatunnel/connectors/seatunnel/graphql/source/reader/GraphQLWebSocket.java
index 6c6631ce10..bae1329353 100644
--- 
a/seatunnel-connectors-v2/connector-graphql/src/main/java/org/apache/seatunnel/connectors/seatunnel/graphql/source/reader/GraphQLWebSocket.java
+++ 
b/seatunnel-connectors-v2/connector-graphql/src/main/java/org/apache/seatunnel/connectors/seatunnel/graphql/source/reader/GraphQLWebSocket.java
@@ -98,8 +98,7 @@ public class GraphQLWebSocket {
         @Override
         public void onFailure(
                 @NotNull WebSocket webSocket, @NotNull Throwable t, @Nullable 
Response response) {
-            log.error("WebSocket connection failed: " + t.getMessage());
-            t.printStackTrace();
+            log.error("WebSocket connection failed", t);
             scheduleReconnect();
         }
 
@@ -108,7 +107,8 @@ public class GraphQLWebSocket {
             try {
                 buffer.put(text);
             } catch (InterruptedException e) {
-                e.printStackTrace();
+                log.error("Failed to put message into buffer", e);
+                Thread.currentThread().interrupt();
             }
         }
 
@@ -139,7 +139,8 @@ public class GraphQLWebSocket {
                                         Thread.sleep(RETRY_DELAY_MS);
                                         connect();
                                     } catch (InterruptedException e) {
-                                        e.printStackTrace();
+                                        log.error("Reconnection attempt 
interrupted", e);
+                                        Thread.currentThread().interrupt();
                                     }
                                 })
                         .start();
diff --git 
a/seatunnel-connectors-v2/connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/sink/SlsSinkWriter.java
 
b/seatunnel-connectors-v2/connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/sink/SlsSinkWriter.java
index 6d6043fea5..933c703225 100644
--- 
a/seatunnel-connectors-v2/connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/sink/SlsSinkWriter.java
+++ 
b/seatunnel-connectors-v2/connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/sink/SlsSinkWriter.java
@@ -77,8 +77,7 @@ public class SlsSinkWriter implements 
SinkWriter<SeaTunnelRow, SlsCommitInfo, Sl
         try {
             this.client.PutLogs(plr);
         } catch (Throwable e) {
-            log.error("write logs failed", e);
-            e.printStackTrace();
+            log.error("Failed to write logs to SLS", e);
             throw new IOException(e);
         }
     }