chl-wxp commented on code in PR #10201:
URL: https://github.com/apache/seatunnel/pull/10201#discussion_r2638453887


##########
seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/config/ElasticsearchSourceOptions.java:
##########
@@ -109,4 +109,14 @@ public class ElasticsearchSourceOptions extends 
ElasticsearchBaseOptions {
                     .defaultValue(100)
                     .withDescription(
                             "Maximum number of hits to be returned with each 
PIT search request. Similar to scroll_size but for PIT API.");
+
+    public static final Option<List<Map<String, Object>>> RUNTIME_FIELDS =
+            Options.key("runtime_fields")
+                    .type(new TypeReference<List<Map<String, Object>>>() {})

Review Comment:
   If runtime_field is determined, there are only three attributes: `name`, 
`type`, and `script`. I suggest creating a new class RuntimeField. For example:
   ```diff
   + public class RuntimeField {
   +    private String name;
   +    private String type;
   +    private String script;
   +}



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to